On Mon 31 Aug 2020 04:01:26 PM CEST, Nir Soffer wrote: > +static int preallocate_falloc(int fd, int64_t current_length, int64_t offset, > + Error **errp) > +{ > +#ifdef CONFIG_POSIX_FALLOCATE > + int result; > + > + if (offset == current_length) > + return 0;
You can also take the chance to add the missing braces here (there's a similar warning for the other patch). Berto