Re: [PATCH] libvhost-user: Add GCC_FMT_ATTR and fix format string

[Philippe Mathieu-Daudé]

On Mon, Aug 31, 2020 at 9:52 PM Philippe Mathieu-Daudé <f4...@amsat.org> wrote:
>
>
> Le jeu. 27 août 2020 23:09, Stefan Weil <s...@weilnetz.de> a écrit :
>>
>> Signed-off-by: Stefan Weil <s...@weilnetz.de>
>> ---
>>  contrib/libvhost-user/libvhost-user.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/contrib/libvhost-user/libvhost-user.c 
>> b/contrib/libvhost-user/libvhost-user.c
>> index 53f16bdf08..ff7ac876f4 100644
>> --- a/contrib/libvhost-user/libvhost-user.c
>> +++ b/contrib/libvhost-user/libvhost-user.c
>> @@ -151,7 +151,7 @@ vu_request_to_string(unsigned int req)
>>      }
>>  }
>>
>> -static void
>> +static void GCC_FMT_ATTR(2, 3)
>>  vu_panic(VuDev *dev, const char *msg, ...)
>>  {
>>      char *buf = NULL;
>> @@ -643,7 +643,7 @@ generate_faults(VuDev *dev) {
>>
>>          if (ioctl(dev->postcopy_ufd, UFFDIO_REGISTER, &reg_struct)) {
>>              vu_panic(dev, "%s: Failed to userfault region %d "
>> -                          "@%p + size:%zx offset: %zx: (ufd=%d)%s\n",
>> +                          "@%016"PRIx64" + size:%zx offset: %zx: 
>> (ufd=%d)%s\n",
>
>
> I thought I had fixed this last month, but I don't have my email backlog,

Ah not it was you =) I remember having looked at it.
https://www.mail-archive.com/qemu-devel@nongnu.org/msg724900.html

> so:
> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org>
>
>>                       __func__, i,
>>                       dev_region->mmap_addr,
>>                       dev_region->size, dev_region->mmap_offset,
>> --
>> 2.28.0
>>
>>