Le 27/08/2020 à 13:03, Chen Qun a écrit : > Clang static code analyzer show warning: > hw/intc/exynos4210_combiner.c:231:9: warning: Value stored to 'val' is never > read > val = s->reg_set[offset >> 2]; > > The default register return value should be return 'val'. > > Reported-by: Euler Robot <euler.ro...@huawei.com> > Signed-off-by: Chen Qun <kuhn.chen...@huawei.com> > --- > Cc: Igor Mitsyanko <i.mitsya...@gmail.com> > Cc: Peter Maydell <peter.mayd...@linaro.org> > > v2->v3: Change default register return value from '0' to 'val = > s->reg_set[offset >> 2]'. > --- > hw/intc/exynos4210_combiner.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/intc/exynos4210_combiner.c b/hw/intc/exynos4210_combiner.c > index b8561e4180..59dd27fb16 100644 > --- a/hw/intc/exynos4210_combiner.c > +++ b/hw/intc/exynos4210_combiner.c > @@ -229,7 +229,6 @@ exynos4210_combiner_read(void *opaque, hwaddr offset, > unsigned size) > TARGET_FMT_plx "offset\n", offset); > } > val = s->reg_set[offset >> 2]; > - return 0; > } > return val; > } >
Applied to my trivial-patches branch. Thanks, Laurent
