On 27/08/2020 08.14, Paolo Bonzini wrote:
> 
> 
> Il gio 27 ago 2020, 06:53 Thomas Huth <th...@redhat.com
> <mailto:th...@redhat.com>> ha scritto:
> 
>     > -else
>     > -  error_exit "pixman >= 0.21.8 not present." \
>     > -      "Please install the pixman devel package."
>     > -fi
> 
>     The "else" part now got completely lost, didn't it?
> 
> 
> It's replaced by "required: have_system" in meson.build. We can add a
> custom "not found" message, but if the current one is not enough we
> should improve Meson so that it figures out a good one from the version
> requirement.

Ah, now it makes sense, thanks for the explanation!

But I've tested the patch now, and it does not work:

.../qemu/meson.build:117:3: ERROR: Unknown variable "have_system".

Should the pixman test maybe be moved to a later spot in the file? It
currently shows up before the have_system variable is initialized...

 Thomas


Reply via email to