On 8/24/20 7:29 AM, Peter Maydell wrote: > +DEF_HELPER_3(vfp_addh, f32, f32, f32, ptr)
We do have an f16 entry in helper-head.h, for documentation purposes. It expands to the same uint32_t, so it doesn't make any practical difference. > +float32 VFP_HELPER(name, h)(float32 a, float32 b, void *fpstp) \ And here it would be better to use uint32_t explicitly, because we're definitely not returning float32. I guess you could see if dh_ctype_f16 works here? But that looks a bit ugly to me. Perhaps we should have introduced a better typedef somewhere... Otherwise, Reviewed-by: Richard Henderson <richard.hender...@linaro.org> r~
