On 8/24/20 9:51 AM, Daniel P. Berrangé wrote:
@@ -916,6 +917,27 @@ Darwin)
# won't work when we're compiling with gcc as a C compiler.
QEMU_CFLAGS="-DOS_OBJECT_USE_OBJC=0 $QEMU_CFLAGS"
HOST_VARIANT_DIR="darwin"
+ cat > GNUmakefile <<'EOF'
+# This file is auto-generated by configure to implicitly switch from a 'make'
+# invocation to 'gmake'
Are we going to run into issues with an in-tree build trying to create
GNUmakefile to switch over to build/, while also creating build/GNUmakefile
to switch from make to gmake?
Don't think so - it just means we'll go through both GNUmakefile in
turn before getting to the real Makefile.
Actually, we won't - the top-level in-tree GNUmakefile calls $(MAKE) -C
build -f Makefile, which means it skips build/GNUmakefile. But on the
other hand, since this series adjusts both places to source
build/config-host.mak, which in turn assigns $MAKE in a timely manner,
the recursion should be run through the correct gmake whether done from
the top-level or directly from within build.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
