> -----Original Message----- > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Wednesday, August 03, 2011 1:41 AM > To: Stefan Weil > Cc: Yoder Stuart-B08248; qemu-devel@nongnu.org > Subject: Re: [PATCH] remove cross prefix from pkg-config command > > On 08/02/2011 11:01 PM, Stefan Weil wrote: > > > > I run cross builds for arm, mips, powerpc and mingw. > > All of them use the cross prefix. When running make, I neither want to > > specify a special PATH nor a PKG_CONFIG_PATH. All I need is something > > like "make -C bin/arm" (each cross target has its own directory with > > the binaries). > > > > The general idea of your patch is ok, but maybe you can modify it so > > the cross prefix is used if there is no PKG_CONFIG_PATH set? > > No, the PKG_CONFIG_PATH can be used by the user to add paths in his home > directory. > > The right fix is to do something like > > -pkg_config="${cross_prefix}${PKG_CONFIG-pkg-config}" > +pkg_config=${PKG_CONFIG-"${cross_prefix}pkg-config"} > > and likewise for all other tools. Then Stuart can use pkg_config=pkg-config. > Stuart, can you > do that?
That works...will re-submit. Stuart
