On Wed, Aug 12, 2020 at 08:25:21PM -0700, Richard Henderson wrote: > This allows header files to declare pointers without pulling > in the entire crypto subsystem. > > Signed-off-by: Richard Henderson <richard.hender...@linaro.org> > --- > include/crypto/cipher.h | 2 -- > include/qemu/typedefs.h | 1 + > 2 files changed, 1 insertion(+), 2 deletions(-)
I'm not in favour of this change or the next. Using #include "cipher.h" is not a burden on the users of the crypto code. Moving typedefs away from the associated struct is a step backwards IMHO. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|