On Thu, Aug 13, 2020 at 2:39 AM Chen Qun <kuhn.chen...@huawei.com> wrote:
>
> Clang static code analyzer show warning:
> hw/virtio/vhost-user.c:606:9: warning: Value stored to 'mr' is never read
> mr = vhost_user_get_mr_data(reg->userspace_addr, &offset, &fd);
> ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Reported-by: Euler Robot <euler.ro...@huawei.com>
> Signed-off-by: Chen Qun <kuhn.chen...@huawei.com>
> ---
> Cc: "Michael S. Tsirkin" <m...@redhat.com>
> Cc: Raphael Norwitz <raphael.norw...@nutanix.com>
> ---
> hw/virtio/vhost-user.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
> index d7e2423762..9c5b4f7fbc 100644
> --- a/hw/virtio/vhost-user.c
> +++ b/hw/virtio/vhost-user.c
> @@ -603,7 +603,7 @@ static void scrub_shadow_regions(struct vhost_dev *dev,
> */
> for (i = 0; i < dev->mem->nregions; i++) {
> reg = &dev->mem->regions[i];
> - mr = vhost_user_get_mr_data(reg->userspace_addr, &offset, &fd);
Reviewed-by: Raphael Norwitz <raphael.norw...@nutanix.com>
> + vhost_user_get_mr_data(reg->userspace_addr, &offset, &fd);
> if (fd > 0) {
> ++fd_num;
> }
> --
> 2.23.0
>
>
