Patchew URL: https://patchew.org/QEMU/20200813073712.4001404-1-kuhn.chen...@huawei.com/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20200813073712.4001404-1-kuhn.chen...@huawei.com Subject: [PATCH 00/11] trivial patchs for static code analyzer fixes === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu - [tag update] patchew/20200813073712.4001404-1-kuhn.chen...@huawei.com -> patchew/20200813073712.4001404-1-kuhn.chen...@huawei.com Switched to a new branch 'test' 4f73727 hw/display/vga:Remove redundant statement in vga_draw_graphic() a501d39 hw/intc: Remove redundant statement in exynos4210_combiner_read() 084ebd8 usb/bus: Remove dead assignment in usb_get_fw_dev_path() 5b26d6a tcg/optimize: Remove redundant statement in tcg_optimize() e628a22 vfio/platform: Remove dead assignment in vfio_intp_interrupt() 565efc1 hw/net/virtio-net:Remove redundant statement in virtio_net_rsc_tcp_ctrl_check() 7b65ac4 hw/virtio/vhost-user:Remove dead assignment in scrub_shadow_regions() 2dd718c target/arm/translate-a64:Remove redundant statement in disas_simd_two_reg_misc_fp16() 47833df target/arm/translate-a64:Remove dead assignment in handle_scalar_simd_shli() e1bb6c3 hw/arm/omap1:Remove redundant statement in omap_clkdsp_read() 39a7d8f hw/arm/virt-acpi-build:Remove dead assignment in build_madt() === OUTPUT BEGIN === 1/11 Checking commit 39a7d8f2d62d (hw/arm/virt-acpi-build:Remove dead assignment in build_madt()) 2/11 Checking commit e1bb6c3e178c (hw/arm/omap1:Remove redundant statement in omap_clkdsp_read()) 3/11 Checking commit 47833df935a6 (target/arm/translate-a64:Remove dead assignment in handle_scalar_simd_shli()) 4/11 Checking commit 2dd718cc1926 (target/arm/translate-a64:Remove redundant statement in disas_simd_two_reg_misc_fp16()) 5/11 Checking commit 7b65ac4ccb9d (hw/virtio/vhost-user:Remove dead assignment in scrub_shadow_regions()) 6/11 Checking commit 565efc12ec2a (hw/net/virtio-net:Remove redundant statement in virtio_net_rsc_tcp_ctrl_check()) 7/11 Checking commit e628a2236e95 (vfio/platform: Remove dead assignment in vfio_intp_interrupt()) 8/11 Checking commit 5b26d6af75bd (tcg/optimize: Remove redundant statement in tcg_optimize()) 9/11 Checking commit 084ebd878ce6 (usb/bus: Remove dead assignment in usb_get_fw_dev_path()) ERROR: space required after that ',' (ctx:VxV) #25: FILE: hw/usb/bus.c:615: + snprintf(fw_path + pos, fw_len - pos, "%s@%lx",qdev_fw_name(qdev), ^ total: 1 errors, 0 warnings, 10 lines checked Patch 9/11 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/11 Checking commit a501d39c72e6 (hw/intc: Remove redundant statement in exynos4210_combiner_read()) 11/11 Checking commit 4f73727eb19d (hw/display/vga:Remove redundant statement in vga_draw_graphic()) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200813073712.4001404-1-kuhn.chen...@huawei.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
