On 05/08/2020 12.01, Philippe Mathieu-Daudé wrote: > 2 trivial patches to fix the link error reported by Thomas: > > LINK tests/test-timed-average.exe > libqemuutil.a(main-loop.o): In function `qemu_notify_event': > util/main-loop.c:139: multiple definition of `qemu_notify_event' > > tests/test-timed-average.o:/builds/huth/qemu/tests/../stubs/notify-event.c:5: > first defined here > collect2: error: ld returned 1 exit status > rules.mak:124: recipe for target 'tests/test-timed-average.exe' failed > > Since v2: > - Remove incorrectly added abort() in qemu_timer_notify_cb()
Works for me (tested here: https://gitlab.com/huth/qemu/-/pipelines/174503835 ) ... but I wonder whether there is a code path that uses the stub from stubs/cpu-get-icount.c but the qemu_notify_event() from util/main-loop.c ? Thomas
