On Jul 30 01:00, Minwoo Im wrote: > On 20-07-20 13:37:42, Klaus Jensen wrote: > > From: Klaus Jensen <k.jen...@samsung.com> > > > > Add 'mdts' device parameter to control the Maximum Data Transfer Size of > > the controller and check that it is respected. > > > > Signed-off-by: Klaus Jensen <k.jen...@samsung.com> > > Reviewed-by: Maxim Levitsky <mlevi...@redhat.com> > > --- > > hw/block/nvme.c | 32 ++++++++++++++++++++++++++++++-- > > hw/block/nvme.h | 1 + > > hw/block/trace-events | 1 + > > 3 files changed, 32 insertions(+), 2 deletions(-) > > > > diff --git a/hw/block/nvme.c b/hw/block/nvme.c > > index 35bc1a7b7e21..10fe53873ae9 100644 > > --- a/hw/block/nvme.c > > +++ b/hw/block/nvme.c > > @@ -18,9 +18,10 @@ > > * Usage: add options: > > * -drive file=<file>,if=none,id=<drive_id> > > * -device nvme,drive=<drive_id>,serial=<serial>,id=<id[optional]>, \ > > - * cmb_size_mb=<cmb_size_mb[optional]>, \ > > + * [cmb_size_mb=<cmb_size_mb>,] \ > > * [pmrdev=<mem_backend_file_id>,] \ > > - * max_ioqpairs=<N[optional]> > > + * [max_ioqpairs=<N>,] \ > > + * [mdts=<N>] > > Nitpick: > cmb and ioqpairs-things could be in another thread. :) >
So, with that I wanted to align the way optional parameters was described. And I actually messed it up anyway. I'll remove the "fixes" and just keep the addition of mdts there.
