On Wed, 29 Jul 2020 at 14:05, Halil Pasic <pa...@linux.ibm.com> wrote:
>
> As pointed out by Peter, g_memdup(ms->loadparm, sizeof(ms->loadparm) + 1)
> reads one past of the end of ms->loadparm, so g_memdup() can not be used
> here.
>
> Let's use malloc and memcpy instead!
>
> Fixes: d664548328 ("s390x/s390-virtio-ccw: fix loadparm property getter")
> Fixes: Coverity CID 1431058
> Reported-by: Peter Maydell <peter.mayd...@linaro.org>
> Signed-off-by: Halil Pasic <pa...@linux.ibm.com>
> ---
> hw/s390x/s390-virtio-ccw.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
> index 403d30e13b..8b7bac0392 100644
> --- a/hw/s390x/s390-virtio-ccw.c
> +++ b/hw/s390x/s390-virtio-ccw.c
> @@ -704,8 +704,8 @@ static char *machine_get_loadparm(Object *obj, Error
> **errp)
> char *loadparm_str;
>
> /* make a NUL-terminated string */
> - loadparm_str = g_memdup(ms->loadparm, sizeof(ms->loadparm) + 1);
> - loadparm_str[sizeof(ms->loadparm)] = 0;
> + loadparm_str = g_malloc0(sizeof(ms->loadparm) + 1);
> + memcpy(loadparm_str, ms->loadparm, sizeof(ms->loadparm));
> return loadparm_str;
> }
(relies on the zeroing of g_malloc0 to put in the terminator
but I guess the existing comment makes that clear enough.)
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org>
thanks
-- PMM
