On Sonntag, 26. Juli 2020 18:14:11 CEST Ed Maste wrote: > On Fri, 24 Jul 2020 at 10:32, Thomas Huth <th...@redhat.com> wrote: > > Compiler warnings currently go unnoticed in our FreeBSD and macOS builds, > > since -Werror is only enabled for Linux and MinGW builds by default. So > > let's enable them here now, too. > > Reviewed-by: Ed Maste <ema...@freebsd.org> > > for the FreeBSD change; I'm indifferent on which method is used to > address the macos deprecation warnings.
Like I pointed out on my response to Peter, it is a bit risky to just blindly link against Apple's version of sasl on macOS. Say you compile qemu on a certain macOS version, then you run qemu again after an update of macOS without recompiling qemu, chances are that you get misbehaviours. One solution would be bundling the qemu app along with sasl, so qemu would be forced to use that bundled sasl version instead of whatever Apple's version of sasl is installed on the system. Another appraoch would be checking the system's sasl version on qemu startup by calling either sasl_version() or sasl_version_info() and comparing that with the version qemu was compiled with, and erroring out on doubt. Or obvious last option: simply taking the risk by ignoring this potential issue. The SASL headers are still made available by Apple, which suggests that they don't break SASL 'too often'. Your choice. ;-) Best regards, Christian Schoenebeck
