Philippe Mathieu-Daudé <phi...@redhat.com> writes: > error_propagate_prepend() "behaves like error_prepend()", and > error_prepend() uses "formatting @fmt, ... like printf()". > error_prepend() checks its format string argument, but > error_propagate_prepend() does not. Fix by addint the format
s/addint/adding/ > attribute to error_propagate_prepend() and error_vprepend(). > > This would have caught the bug fixed in the previous commit: > > CC hw/sd/milkymist-memcard.o > hw/sd/milkymist-memcard.c: In function ‘milkymist_memcard_realize’: > hw/sd/milkymist-memcard.c:284:70: error: format ‘%s’ expects a matching > ‘char *’ argument [-Werror=format=] > 284 | error_propagate_prepend(errp, err, "failed to init SD card: > %s"); > | > ~^ > | > | > | > char * I see no need to repeat the details here. If you agree, I'll drop them in my tree. > Missed in commit 4b5766488f "error: Fix use of error_prepend() with > &error_fatal, &error_abort". > > Inspired-by: Stefan Weil <s...@weilnetz.de> > Suggested-by: Eric Blake <ebl...@redhat.com> > Reviewed-by: Markus Armbruster <arm...@redhat.com> > Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com> Reviewed-by: Markus Armbruster <arm...@redhat.com>
