On 24/07/2020 09.16, Philippe Mathieu-Daudé wrote: > At least one of softmmu or user mode has to be enabled to use > capstone. If not, don't clone/built it. > > This save CI time for the tools/documentation-only build jobs. > > Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> > --- > configure | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/configure b/configure > index 4bd80ed507..bc5757159a 100755 > --- a/configure > +++ b/configure > @@ -5381,6 +5381,10 @@ fi > ########################################## > # capstone > > +if test -z "$capstone" && test $tcg = 'no' ; then # !tcg implies !softmmu > + capstone="no" > +fi
I don't think this is right. You could have a KVM-only build where you still want to use the disassembler for the human monitor. But maybe it could be disabled if softmmu="no", linux_user="no" and bsd_user="no" ? Thomas
