On Fri, 3 Jul 2020 at 17:10, Lukas Straub <lukasstra...@web.de> wrote: > > On Thu, 25 Jun 2020 10:30:24 +0100 > Peter Maydell <peter.mayd...@linaro.org> wrote: > > > On Thu, 18 Jun 2020 at 14:23, Jason Wang <jasow...@redhat.com> wrote: > > > > > > From: Lukas Straub <lukasstra...@web.de> > > > > > > In colo_compare_complete, insert CompareState into net_compares > > > only after everything has been initialized. > > > In colo_compare_finalize, remove CompareState from net_compares > > > before anything is deinitialized. > > > > Hi; this code-motion seems to have prompted Coverity to > > discover a possible deref-of-NULL-pointer (cID 1429969):
> > Either we need to avoid calling this if s->iothread is NULL, > > or if it can't ever be NULL then the earlier NULL check was > > pointless and can be removed. > > I'll look into it. Did you send a fix for this? I couldn't find one in a quick search of my mail archive... thanks -- PMM
