> > +/* > > + * Building devices and other qom objects modular is mostly useful in > > + * case they have dependencies to external shared libraries, so we can > > + * cut down the core qemu library dependencies. Which is the case for > > + * only a very few devices & objects. > > + * > > + * So with the expectation that this will be rather the exception than > > + * to rule and the list will not gain that many entries go with a > > Nit: Add a comma after "entries" > > I would also indicate that this list needs to be sorted by prefix/module
Done (incremental patch, series is merged already). > > + const char *type; > > + const char *prefix; > > + const char *module; > > Because of the sorting rule, it is more intuitive to put the module first > and the type last, for cases where you have > > mod1 prefix1 type1 > mod1 prefix1 type2 > mod1 prefix1 type3 > mod2 prefix2 type1 > > Visually, I expect the constants to come first. I see it more as a object-type -> module lookup table, thats why the type comes first ... take care, Gerd
