On 7/20/20 4:01 PM, Eduardo Habkost wrote:
On Mon, Jul 20, 2020 at 12:02:52PM -0400, John Snow wrote:
3 seconds is too short for some tests running inside busy VMs. Build it out to
a rather generous 30 seconds to find out conclusively if there are more severe
problems in the merge/CI tests.

Signed-off-by: John Snow <js...@redhat.com>

I would send my Reviewed-by to this patch without blinking if it
only changed the default value without touching anything else,
but this changes argument order and defaults in 4 different
methods.

I will still review this, though, and I will probably reply in a
few minutes with my Reviewed-by.

sorry, couldn't help myself ...

Since I changed the default, I thought it was better to remove the default in the inner methods that can't be called by client code anyway.


Reply via email to