> -----Original Message----- > From: Peter Maydell <peter.mayd...@linaro.org> > Sent: Sunday, July 12, 2020 2:50 AM > To: Wu, Wentong <wentong...@intel.com> > Cc: QEMU Developers <qemu-devel@nongnu.org>; QEMU Trivial > <qemu-triv...@nongnu.org>; Chris Wulff <crwu...@gmail.com>; Marek Vasut > <ma...@denx.de> > Subject: Re: [PATCH v2 1/4] target/nios2: add DISAS_NORETURN case for nothing > more to generate > > On Fri, 10 Jul 2020 at 16:46, Wentong Wu <wentong...@intel.com> wrote: > > > > Add DISAS_NORETURN case for nothing more to generate because at > > runtime execution will never return from some helper call. And at the > > same time replace DISAS_UPDATE in t_gen_helper_raise_exception and > > gen_exception with the newly added DISAS_NORETURN. > > > > Signed-off-by: Wentong Wu <wentong...@intel.com> > > Hi; I'm going to pick these up and get them into master. > > A couple of notes below for if you plan to submit more patches to QEMU in > future: these are really just minor workflow things, but they do help make > our lives easier in getting code submissions into the tree.
Thanks Peter, I will follow the process to submit more patches to QEMU project, and I really learn a lot! Thanks > If people provide you with a Reviewed-by: tag for a patch, and you don't > change it when you send out an updated version, it's helpful if you include > that tag in the commit message of the revised version you send out. This > saves people having to remember whether they'd reviewed something or not, and > means that when applying I don't have to go back and look at old versions to > see who reviewed what. > > Patch series are much easier for our tooling to deal with if you send them > out with a cover letter email (a 0/n email which all the other emails are > followups to; git format-patch has a '--cover-letter' option which will do > the right thing here). > > We document this kind of workflow stuff here: > https://wiki.qemu.org/Contribute/SubmitAPatch > > thanks > -- PMM
