On Fri, Jul 10, 2020 at 11:36 AM Alistair Francis <alistai...@gmail.com> wrote: > > On Thu, Jul 9, 2020 at 10:11 PM Bin Meng <bmeng...@gmail.com> wrote: > > > > From: Bin Meng <bin.m...@windriver.com> > > > > Update the install blob list to include the generic platform > > fw_dynamic bios images. > > > > Signed-off-by: Bin Meng <bin.m...@windriver.com> > > You didn't address the comments in v3. > > Thinking about this more though it looks like we currently don't > install anything, so this is an improvement. > > Reviewed-by: Alistair Francis <alistair.fran...@wdc.com>
Nope, I was wrong. This should be squashed into patch 4 where you remove the installed binaries. Alistair > > Alistair > > > > > --- > > > > (no changes since v3) > > > > Changes in v3: > > - change fw_jump to fw_dynamic in the Makefile > > > > Changes in v2: > > - new patch: Makefile: Ship the generic platform bios images for RISC-V > > > > Makefile | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/Makefile b/Makefile > > index f06b3ae..05e05bb 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -840,7 +840,9 @@ palcode-clipper \ > > u-boot.e500 u-boot-sam460-20100605.bin \ > > qemu_vga.ndrv \ > > edk2-licenses.txt \ > > -hppa-firmware.img > > +hppa-firmware.img \ > > +opensbi-riscv32-generic-fw_dynamic.bin > > opensbi-riscv32-generic-fw_dynamic.elf \ > > +opensbi-riscv64-generic-fw_dynamic.bin > > opensbi-riscv64-generic-fw_dynamic.elf > > > > > > DESCS=50-edk2-i386-secure.json 50-edk2-x86_64-secure.json \ > > -- > > 2.7.4 > > > >
