On 7/10/20 3:48 AM, frank.ch...@sifive.com wrote: > # *** Vector loads and stores are encoded within LOADFP/STORE-FP *** > -vlb_v ... 100 . 00000 ..... 000 ..... 0000111 @r2_nfvm > -vlh_v ... 100 . 00000 ..... 101 ..... 0000111 @r2_nfvm > -vlw_v ... 100 . 00000 ..... 110 ..... 0000111 @r2_nfvm
Again, something you can't do until 0.7.1 is not supported. If you don't want to simultaneously support 0.7.1 and 0.9/1.0, then you should simply remove 0.7.1 in the first patch, so that there's no confusion. Is the rest of it mostly renaming? You should definitely expand on what you're doing within each patch description. A description of what has changed in the spec since 0.7.1 will help the reviewer validate that you've gotten all of the corner cases. I am going to stop reviewing this patch series now, as I expect that most of the remaining patches will have similar comments. r~
