On 09/07/2020 07.09, Philippe Mathieu-Daudé wrote: > On 7/9/20 7:03 AM, Philippe Mathieu-Daudé wrote: >> On 7/8/20 10:01 PM, Alexander Bulekov wrote: >>> In 45222b9a90, I fixed a broken check for rcu_enable_atfork introduced >>> in d6919e4cb6. I added a call to rcu_enable_atfork after the >>> call to qemu_init in fuzz.c, but forgot to include the corresponding >>> header, breaking --enable-fuzzing --enable-werror builds. >>> >>> Fixes: 45222b9a90 ("fuzz: fix broken qtest check at rcu_disable_atfork") >>> Signed-off-by: Alexander Bulekov <alx...@bu.edu> >>> --- >>> tests/qtest/fuzz/fuzz.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/tests/qtest/fuzz/fuzz.c b/tests/qtest/fuzz/fuzz.c >>> index a36d9038e0..0b66e43409 100644 >>> --- a/tests/qtest/fuzz/fuzz.c >>> +++ b/tests/qtest/fuzz/fuzz.c >>> @@ -19,6 +19,7 @@ >>> #include "sysemu/runstate.h" >>> #include "sysemu/sysemu.h" >>> #include "qemu/main-loop.h" >>> +#include "qemu/rcu.h" >>> #include "tests/qtest/libqtest.h" >>> #include "tests/qtest/libqos/qgraph.h" >>> #include "fuzz.h" >>> >> >> Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com> >> > > Please add the include to softmmu/vl.c too.
Why? Did you run into compile problems here, too? Thomas