Am 08.07.2020 um 17:48 hat Paolo Bonzini geschrieben: > On 06/03/20 18:14, Kevin Wolf wrote: > > Mapping object-add to the command line as is doesn't result in nice > > syntax because of the nesting introduced with 'props'. This becomes > > nicer and more consistent with device_add and netdev_add when we accept > > properties for the object on the top level instead. > > > > 'props' is still accepted after this patch, but marked as deprecated. > > > > Signed-off-by: Kevin Wolf <kw...@redhat.com> > > Message-Id: <20200224143008.13362-8-kw...@redhat.com> > > Acked-by: Stefan Hajnoczi <stefa...@redhat.com> > > Signed-off-by: Kevin Wolf <kw...@redhat.com> > > Hi Kevin and Markus, > > I just noticed this patch. In my opinion "nice syntax" is not a good > argument for having a "gen: false" command that is even less > introspectable than the "props" argument.
Markus was going to introduce new QAPI schema syntax that would allow to specify a few options explicitly and then one option for "the rest" that would just be mapped to a QDict like "any" or "gen": false, and that wouldn't require any nesting. I'm not sure if any progress was made there, but making things consistent between device_add, netdev_add and object_add was a step in this direction anyway. > As an aside, it would have been nice to run this through Markus and me, > though in all fairness I'm not sure I would have been responsive back > in February. It went through my tree because of the other patches in the series, but I wrote this patch specifically at Markus's request. > I would like to un-deprecate this for 5.1, and revert it in either 5.1 > or 5.2. (Also I will be away next week, so the decision would have to > be taken quickly). Please discuss it with Markus then. Kevin
