On 7/8/20 6:58 PM, Havard Skinnemoen wrote: > On Wed, Jul 8, 2020 at 9:56 AM Philippe Mathieu-Daudé <f4...@amsat.org> wrote: >>> +config NPCM7XX >>> + bool >>> + select A9MPCORE >>> + select ARM_GIC >>> + select PL310 # cache controller >>> + select SERIAL >>> + select UNIMP >> >> And this in patch 5: "Add NPCM730 and NPCM750 SoC models" > > Is it still OK for earlier patches to use $(CONFIG_NPCM7XX) in Makefiles? >
I haven't reviewed them yet, so no. I'd do this way: - Add to the first peripheral that requires $(CONFIG_NPCM7XX): config NPCM7XX bool - Then when you add the SoC, complete with: select A9MPCORE select ARM_GIC select PL310 # cache controller select SERIAL select UNIMP