Hi Stefan,
On 7/7/20 6:05 AM, Stefan Berger wrote:
> Exit on TPM backend failures in the same way as the TPM CRB and TIS device
> models do.
Maybe the other models are not the best examples ;)
>
> Signed-off-by: Stefan Berger <stef...@linux.ibm.com>
> ---
> hw/tpm/tpm_spapr.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/hw/tpm/tpm_spapr.c b/hw/tpm/tpm_spapr.c
> index cb4dfd1e6a..8288ab0a15 100644
> --- a/hw/tpm/tpm_spapr.c
> +++ b/hw/tpm/tpm_spapr.c
> @@ -306,7 +306,10 @@ static void tpm_spapr_reset(SpaprVioDevice *dev)
> TPM_SPAPR_BUFFER_MAX);
>
> tpm_backend_reset(s->be_driver);
> - tpm_spapr_do_startup_tpm(s, s->be_buffer_size);
> +
> + if (tpm_spapr_do_startup_tpm(s, s->be_buffer_size) < 0) {
I don't see error reported, how users can know the cause of the exit?
> + exit(1);
What about using this instead?
qemu_system_shutdown_request(SHUTDOWN_CAUSE_HOST_ERROR);
> + }
> }
>
> static enum TPMVersion tpm_spapr_get_version(TPMIf *ti)
>
