On Tue, Jun 30, 2020 at 6:45 AM Philippe Mathieu-Daudé <f4...@amsat.org> wrote:
>
> Add more descriptive comments to keep a clear separation
> between static property vs runtime changeable.
>
> Suggested-by: Peter Maydell <peter.mayd...@linaro.org>
> Reviewed-by: Peter Maydell <peter.mayd...@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org>
Reviewed-by: Alistair Francis <alistair.fran...@wdc.com>
Alistair
> ---
> hw/sd/sd.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/hw/sd/sd.c b/hw/sd/sd.c
> index 5d1b314a32..723e66bbf2 100644
> --- a/hw/sd/sd.c
> +++ b/hw/sd/sd.c
> @@ -103,11 +103,14 @@ struct SDState {
> uint32_t card_status;
> uint8_t sd_status[64];
>
> - /* Configurable properties */
> + /* Static properties */
> +
> uint8_t spec_version;
> BlockBackend *blk;
> bool spi;
>
> + /* Runtime changeables */
> +
> uint32_t mode; /* current card mode, one of SDCardModes */
> int32_t state; /* current card state, one of SDCardStates */
> uint32_t vhs;
> --
> 2.21.3
>
>
