On 06/07/2020 16.56, Eric Blake wrote: > On 7/5/20 9:03 AM, Thomas Huth wrote: >> From: Michael Rolnik <mrol...@gmail.com> >> >> Add AVR related definitions into QEMU. >> >> [AM: Remove word 'Atmel' from filenames and all elements of code] >> Suggested-by: Aleksandar Markovic <aleksandar.m.m...@gmail.com> >> Signed-off-by: Michael Rolnik <mrol...@gmail.com> >> Signed-off-by: Richard Henderson <richard.hender...@linaro.org> >> Signed-off-by: Aleksandar Markovic <aleksandar.m.m...@gmail.com> >> Tested-by: Philippe Mathieu-Daudé <phi...@redhat.com> >> Reviewed-by: Aleksandar Markovic <amarko...@wavecomp.com> >> Signed-off-by: Thomas Huth <h...@tuxfamily.org> >> --- > >> +++ b/qapi/machine.json >> @@ -25,7 +25,7 @@ >> # Since: 3.0 >> ## > > Missing a line that resembles: > > # @avr since 5.1
I thought that we stopped doing that ... but apparently, my memory was wrong and this was only about the "dropped" statements (see commit id bb5ccf225e81d2). Ok, I can add that again (though it's somewhat strange that we removed the "dropped" statements but still keep the "since" statements...?) Thomas