On 03/07/2020 16.56, Peter Maydell wrote: > From: David CARLIER <devne...@gmail.com> > > Instead of using an OS-specific ifdef test to select the "openpty() > is in pty.h" codepath, make configure check for the existence of > the header and use the new CONFIG_PTY instead. > > This is necessary to build on Haiku, which also provides openpty() > via pty.h. > > Signed-off-by: David Carlier <devne...@gmail.com> > [PMM: Expanded commit message] > Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > --- > configure | 9 +++++++++ > util/qemu-openpty.c | 2 +- > 2 files changed, 10 insertions(+), 1 deletion(-) [...] > diff --git a/util/qemu-openpty.c b/util/qemu-openpty.c > index 2e8b43bdf57..9d8ad6905e0 100644 > --- a/util/qemu-openpty.c > +++ b/util/qemu-openpty.c > @@ -35,7 +35,7 @@ > #include "qemu/osdep.h" > #include "qemu-common.h" > > -#if defined(__GLIBC__) > +#if defined CONFIG_PTY
Shouldn't there be some parentheses around CONFIG_PTY here? Thomas
