Christoph Hellwig <h...@lst.de> writes: > On Wed, Jul 20, 2011 at 06:23:44PM +0200, Markus Armbruster wrote: >> Drop WIN_SRST, it has same value as WIN_DEVICE_RESET. >> >> CFA_IDLEIMMEDIATE isn't specific to CFATA. ACS-2 shows it as a >> defined command in ATA-1, -2 and -3. Rename to WIN_IDLEIMMEDIATE2. >> >> Turn unused macros into comments. > > I don't think that part is overly helpful. In general you'd want to > keep all defines for protocol headers, just to make it easier to > actually use them later on.
Which ones to keep? Just non-obsolete ones? According to which version of the standard?
