Re: [PATCH v2 12/12] vhost-vdpa: introduce vhost-vdpa net client

[Eric Blake]

On 6/30/20 12:49 PM, Cindy Lu wrote:

This patch set introduces a new net client type: vhost-vdpa.
vhost-vdpa net client will set up a vDPA device which is specified
by a "vhostdev" parameter.

Signed-off-by: Lingshan Zhu <lingshan....@intel.com>
Signed-off-by: Tiwei Bie <tiwei....@intel.com>
Signed-off-by: Cindy Lu <l...@redhat.com>
---

+++ b/qapi/net.json
@@ -428,16 +428,37 @@
      '*vhostforce':    'bool',
      '*queues':        'int' } }

+##

+# @NetdevVhostVDPAOptions:
+#
+# Vhost-vdpa network backend
+#
+# vDPA device is a device that uses a datapath which complies with the virtio
+# specifications with a vendor specific control path.
+#
+# @vhostdev: path of vhost-vdpa device
+#            (default:'/dev/vhost-vdpa-0')
+#
+# @queues: number of queues to be created for multiqueue vhost-vdpa
+#          (default: 1)
+#
+# Since: 5.1
+##
+{ 'struct': 'NetdevVhostVDPAOptions',
+  'data': {
+    '*vhostdev':     'str',
+    '*queues':       'int' } }
+
  ##
  # @NetClientDriver:
  #
  # Available netdev drivers.
  #
-# Since: 2.7
+# Since: 5.1

This should be:

# Since: 2.7
# @vhost-vdpa since 5.1

since the enum has been around a lot longer than the latest addition to it.

  ##
  { 'enum': 'NetClientDriver',
    'data': [ 'none', 'nic', 'user', 'tap', 'l2tpv3', 'socket', 'vde',
-            'bridge', 'hubport', 'netmap', 'vhost-user' ] }
+            'bridge', 'hubport', 'netmap', 'vhost-user', 'vhost-vdpa' ] }

##

  # @Netdev:
@@ -465,7 +486,8 @@
      'bridge':   'NetdevBridgeOptions',
      'hubport':  'NetdevHubPortOptions',
      'netmap':   'NetdevNetmapOptions',
-    'vhost-user': 'NetdevVhostUserOptions' } }
+    'vhost-user': 'NetdevVhostUserOptions',
+    'vhost-vdpa': 'NetdevVhostVDPAOptions' } }

##

  # @NetFilterDirection:

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org