On Mon, 29 Jun 2020 at 13:09, Dr. David Alan Gilbert <dgilb...@redhat.com> wrote: > > * Peter Maydell (peter.mayd...@linaro.org) wrote: > > Here we call qemu_sem_timedwait() but ignore the return value, > > whereas all the other callsites for that function do something > > with the return value. Is the code correct? (This is just a > > heuristic Coverity has, and it's wrong a fair amount of the > > time, so if it's wrong here too I can just mark it as a > > false-positive in the Coverity UI.) > > Hmm it's OK; that semaphore isn't really used at the moment, > so it's pretty much just a sleep. And the loop always > calls the qemu_savevm_state_guest_unplug_pending() before > it goes around again; so it doesn't care if the return > value indicates timeout or not.
Thanks; have marked it as a false-positive in the UI. -- PMM
