уто, 2. јун 2020. у 00:19 Richard Henderson <richard.hender...@linaro.org> је написао/ла: > > On 5/31/20 6:45 AM, Ahmed Karaman wrote: > > Add the page crossings check in use_goto_tb(). If this check is not > > applied, a number of bugs may occasionally occur during target rx > > system mode emulation. > > Also, this check is needed in user mode related to emulation of system > > call mmap(). rx target does not currently support user mode, but it is > > better to prepare use_goto_tb() in that sense in advance. > > > > Rename parameter dc of type DisasContext* to the more common name ctx, > > to keep consistency with other targets. > > > > Add detailed comments. > > > > Buglink: https://bugs.launchpad.net/qemu/+bug/1880763 > > Signed-off-by: Ahmed Karaman <ahmedkhaledkara...@gmail.com> > > --- > > target/rx/translate.c | 9 ++++++--- > > 1 file changed, 6 insertions(+), 3 deletions(-) > > Reviewed-by: Richard Henderson <richard.hender...@linaro.org> >
If there is no objection, I plan to select this patch in the upcoming "TCG Continuous Benchmarking" project queue. Thanks to Richard and Ahmed! Aleksandar > Although I note that this failure is not currently visible because RX does not > have an MMU. So there are no page permissions to change or fail. > > > r~ >
