Patchew URL: https://patchew.org/QEMU/20200624075226.92728-1-fran...@linux.ibm.com/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v5 00/12] pc-bios: s390x: Cleanup part 1 Type: series Message-id: 20200624075226.92728-1-fran...@linux.ibm.com === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu * [new tag] patchew/20200624075226.92728-1-fran...@linux.ibm.com -> patchew/20200624075226.92728-1-fran...@linux.ibm.com Switched to a new branch 'test' f7789d0 pc-bios: s390x: Cleanup jump to ipl code 8680ca2 pc-bios: s390x: Fix bootmap.c passing PSWs as addresses 830483b pc-bios: s390x: Make u32 ptr check explicit f313bb2 pc-bios: s390x: Use ebcdic2ascii table 00728a2 pc-bios: s390x: Move panic() into header and add infinite loop d025a9c pc-bios: s390x: Use PSW masks where possible and introduce PSW_MASK_SHORT_ADDR e33e9ff pc-bios: s390x: Rename PSW_MASK_ZMODE to PSW_MASK_64 c98ec6e pc-bios: s390x: Remove unneeded dasd-ipl.c reset psw mask changes f22b573 pc-bios: s390x: Get rid of magic offsets into the lowcore aafb016 pc-bios: s390x: Move sleep and yield to helper.h 855c1c9 pc-bios: s390x: Consolidate timing functions into time.h b906f41 pc-bios: s390x: cio.c cleanup and compile fix === OUTPUT BEGIN === 1/12 Checking commit b906f41df28f (pc-bios: s390x: cio.c cleanup and compile fix) 2/12 Checking commit 855c1c9be4fe (pc-bios: s390x: Consolidate timing functions into time.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #94: new file mode 100644 total: 0 errors, 1 warnings, 142 lines checked Patch 2/12 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/12 Checking commit aafb016fdfe0 (pc-bios: s390x: Move sleep and yield to helper.h) 4/12 Checking commit f22b573bc73e (pc-bios: s390x: Get rid of magic offsets into the lowcore) ERROR: spaces required around that ':' (ctx:VxV) #30: FILE: pc-bios/s390-ccw/cio.h:127: + __u16 cssid:8; ^ ERROR: spaces required around that ':' (ctx:VxV) #31: FILE: pc-bios/s390-ccw/cio.h:128: + __u16 reserved:4; ^ ERROR: spaces required around that ':' (ctx:VxV) #32: FILE: pc-bios/s390-ccw/cio.h:129: + __u16 m:1; ^ ERROR: spaces required around that ':' (ctx:VxV) #33: FILE: pc-bios/s390-ccw/cio.h:130: + __u16 ssid:2; ^ ERROR: spaces required around that ':' (ctx:VxV) #34: FILE: pc-bios/s390-ccw/cio.h:131: + __u16 one:1; ^ total: 5 errors, 0 warnings, 37 lines checked Patch 4/12 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/12 Checking commit c98ec6eb101b (pc-bios: s390x: Remove unneeded dasd-ipl.c reset psw mask changes) 6/12 Checking commit e33e9fff145a (pc-bios: s390x: Rename PSW_MASK_ZMODE to PSW_MASK_64) 7/12 Checking commit d025a9ce4c67 (pc-bios: s390x: Use PSW masks where possible and introduce PSW_MASK_SHORT_ADDR) 8/12 Checking commit 00728a2fdf9e (pc-bios: s390x: Move panic() into header and add infinite loop) 9/12 Checking commit f313bb25948c (pc-bios: s390x: Use ebcdic2ascii table) 10/12 Checking commit 830483bf940d (pc-bios: s390x: Make u32 ptr check explicit) 11/12 Checking commit 8680ca210f71 (pc-bios: s390x: Fix bootmap.c passing PSWs as addresses) 12/12 Checking commit f7789d0e1906 (pc-bios: s390x: Cleanup jump to ipl code) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200624075226.92728-1-fran...@linux.ibm.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com