QAPI schema review only.
Cindy Lu <l...@redhat.com> writes:
> This patch set introduces a new net client type: vhost-vdpa.
> vhost-vdpa net client will set up a vDPA device which is specified
> by a "vhostdev" parameter.
>
> Signed-off-by: Lingshan Zhu <lingshan....@intel.com>
> Signed-off-by: Tiwei Bie <tiwei....@intel.com>
> Signed-off-by: Cindy Lu <l...@redhat.com>
[...]
> diff --git a/qapi/net.json b/qapi/net.json
> index cebb1b52e3..03aad67693 100644
> --- a/qapi/net.json
> +++ b/qapi/net.json
> @@ -428,6 +428,24 @@
> '*vhostforce': 'bool',
> '*queues': 'int' } }
>
> +##
> +# @NetdevVhostVDPAOptions:
> +#
> +# Vhost-vdpa network backend
Considering this ends up in QMP reference documentation, could you add a
hint on what "Vhost-vdpa" is?
> +#
> +# @vhostdev: name of a vdpa dev path in sysfs
How is this thing to be spelled in text, vdpa, VDPA or vDPA?
Avoid unnecessary abbreviations in doc text, please: write "device
path", not "dev path".
> +# (default path:/dev/vhost-vdpa-$ID)
What's $ID?
> +#
> +# @queues: number of queues to be created for multiqueue vhost-vdpa
> +# (default: 1)
> +#
> +# Since: 5.1
> +##
> +{ 'struct': 'NetdevVhostVDPAOptions',
> + 'data': {
> + '*vhostdev': 'str',
> + '*queues': 'int' } }
> +
> ##
> # @NetClientDriver:
> #
> @@ -437,7 +455,7 @@
> ##
> { 'enum': 'NetClientDriver',
> 'data': [ 'none', 'nic', 'user', 'tap', 'l2tpv3', 'socket', 'vde',
> - 'bridge', 'hubport', 'netmap', 'vhost-user' ] }
> + 'bridge', 'hubport', 'netmap', 'vhost-user', 'vhost-vdpa' ] }
>
> ##
> # @Netdev:
> @@ -465,7 +483,8 @@
> 'bridge': 'NetdevBridgeOptions',
> 'hubport': 'NetdevHubPortOptions',
> 'netmap': 'NetdevNetmapOptions',
> - 'vhost-user': 'NetdevVhostUserOptions' } }
> + 'vhost-user': 'NetdevVhostUserOptions',
> + 'vhost-vdpa': 'NetdevVhostVDPAOptions' } }
>
> ##
> # @NetLegacy:
