On 22/06/2020 09.42, Janosch Frank wrote: > panic() was defined for the ccw and net bios, i.e. twice, so it's > cleaner to rather put it into the header. > > Also let's add an infinite loop into the assembly of disabled_wait() so > the caller doesn't need to take care of it. > > Signed-off-by: Janosch Frank <fran...@linux.ibm.com> > Reviewed-by: Pierre Morel <pmo...@linux.ibm.com> > Reviewed-by: David Hildenbrand <da...@redhat.com> > Reviewed-by: Thomas Huth <th...@redhat.com> > --- > pc-bios/s390-ccw/main.c | 7 ------- > pc-bios/s390-ccw/netmain.c | 8 -------- > pc-bios/s390-ccw/s390-ccw.h | 9 +++++++-- > pc-bios/s390-ccw/start.S | 5 +++-- > 4 files changed, 10 insertions(+), 19 deletions(-) [...] > diff --git a/pc-bios/s390-ccw/start.S b/pc-bios/s390-ccw/start.S > index aa8fceb19d..35be141d8d 100644 > --- a/pc-bios/s390-ccw/start.S > +++ b/pc-bios/s390-ccw/start.S > @@ -47,8 +47,9 @@ memsetxc: > */ > .globl disabled_wait > disabled_wait: > - larl %r1,disabled_wait_psw > - lpswe 0(%r1) > + larl %r1,disabled_wait_psw > + lpswe 0(%r1) > +1: j 1b
Could you please fix the white spaces here while you're at it (TABs vs. spaces). Thanks, Thomas
