Bastian Koppelmann <kbast...@mail.uni-paderborn.de> writes:
> On Tue, Jun 16, 2020 at 05:22:42PM +0100, Alex Bennée wrote: >> >> Bastian Koppelmann <kbast...@mail.uni-paderborn.de> writes: >> >> > when trying to run successful short tests from the Makefile timeout would >> > no >> > terminate. Rather it would wait until the time runs out. Excerpt from the >> > manpage: >> >> Which tests hang without this change? > > The TriCore tests ;). Hmm I wonder why? All the other tests work so is this a function of output from the test? The softmmu tests for example usually redirect their output via a chardev device. Tests which require actual input from the user are skipped (the semiconsole test is MANUAL only). > >> >> > >> > --foreground >> > when not running timeout directly from a shell prompt, >> > allow COMMAND to read from the TTY and get TTY signals; in this mode, >> > chil‐ >> > dren of COMMAND will not be timed out >> > >> > Signed-off-by: Bastian Koppelmann <kbast...@mail.uni-paderborn.de> >> > --- >> > tests/tcg/Makefile.target | 5 +++-- >> > 1 file changed, 3 insertions(+), 2 deletions(-) >> > >> > diff --git a/tests/tcg/Makefile.target b/tests/tcg/Makefile.target >> > index b3cff3cad1..423caffa56 100644 >> > --- a/tests/tcg/Makefile.target >> > +++ b/tests/tcg/Makefile.target >> > @@ -40,9 +40,10 @@ quiet-command = $(if $(V),$1,$(if $(2),@printf " %-7s >> > %s\n" $2 $3 && $1, @$1)) >> > >> > # $1 = test name, $2 = cmd, $3 = desc >> > ifdef CONFIG_USER_ONLY >> > -run-test = $(call quiet-command, timeout $(TIMEOUT) $2 > $1.out,"TEST",$3) >> > +run-test = $(call quiet-command, timeout --foreground $(TIMEOUT) $2 > >> > $1.out \ >> > + "TEST",$3) >> >> This breaks make check-tcg due to a dropped , > > Whoops > > Cheers, > Bastian -- Alex Bennée
