Patchew URL: https://patchew.org/QEMU/20200611194449.31468-1-pbonz...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200611194449.31468-1-pbonz...@redhat.com Subject: [PULL 000/115] Huge miscellaneous pull request for 2020-06-11 Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20200612014606.147691-1-...@google.com -> patchew/20200612014606.147691-1-...@google.com Switched to a new branch 'test' b258374 target/i386: Remove obsolete TODO file ed8ffec stubs: move Xen stubs to accel/ 9da3214 replay: fix replay shutdown for console mode 8cf1910 exec/cpu-common: Move MUSB specific typedefs to 'hw/usb/hcd-musb.h' b4bf922 hw/usb: Move device-specific declarations to new 'hcd-musb.h' header 5988475 exec/memory: Remove unused MemoryRegionMmio type 79d4c74 checkpatch: reversed logic with acpi test checks 11943a6 target/i386: sev: Unify SEVState and SevGuestState 722d1df target/i386: sev: Remove redundant handle field ef7e4eb target/i386: sev: Remove redundant policy field c0fa653 target/i386: sev: Remove redundant cbitpos and reduced_phys_bits fields 832d459 target/i386: sev: Partial cleanup to sev_state global 560d42b target/i386: sev: Embed SEVState in SevGuestState 56fe4d8 target/i386: sev: Rename QSevGuestInfo 4902392 target/i386: sev: Move local structure definitions into .c file b8dc835 target/i386: sev: Remove unused QSevGuestInfoClass 5ec6d66 xen: fix build without pci passthrough 93262a0 i386: hvf: Drop HVFX86EmulatorState b52a4bf i386: hvf: Move mmio_buf into CPUX86State 20208b4 i386: hvf: Move lazy_flags into CPUX86State df05641 i386: hvf: Drop regs in HVFX86EmulatorState e978983 i386: hvf: Drop copy of RFLAGS defines 0141723 i386: hvf: Drop rflags from HVFX86EmulatorState e1de961 i386: hvf: Drop fetch_rip from HVFX86EmulatorState ed88ce7 i386: hvf: Use IP from CPUX86State ddb005d i386: hvf: Use ins_len to advance IP c4d282b i386: hvf: Drop unused variable b587a1b i386: hvf: Drop useless declarations in sysemu 7e1a493 i386: hvf: Move HVFState definition into hvf 709b437 target/ppc: Restrict PPCVirtualHypervisorClass to system-mode 238000a sysemu/hvf: Only declare hvf_allowed when HVF is available 3b8e276 sysemu/tcg: Only declare tcg_allowed when TCG is available acb8d15 sysemu/accel: Restrict machine methods to system-mode f9bd95e target/i386: correct fix for pcmpxstrx substring search 136df11 target/i386: fix IEEE x87 floating-point exception raising f843bd2 exec: set map length to zero when returning NULL 3bd81db configure: Do not ignore malloc value 98e8ed2 qemu/thread: Mark qemu_thread_exit() with 'noreturn' attribute 3f5bb0f memory: Make 'info mtree' not display disabled regions by default a3aaf5e util/oslib: Returns the real thread identifier on FreeBSD and NetBSD 6aa0a68 target/i386: define a new MSR based feature word - FEAT_PERF_CAPABILITIES f21430a i386: Remove unused define's from hax and hvf c130d2b replay: implement fair mutex 06644d9 hw/i386/amd_iommu: Fix the reserved bits definition of IOMMU commands 0abe63e tests: machine-none-test: Enable MicroBlaze testing 85f319e chardev/char-socket: Properly make qio connections non blocking d0110c6 KVM: Kick resamplefd for split kernel irqchip 1ead965 KVM: Pass EventNotifier into kvm_irqchip_assign_irqfd 2b7dab6 vfio/pci: Use kvm_irqchip_add_irqfd_notifier_gsi() for irqfds dd32581 x86/cpu: Enable AVX512_VP2INTERSECT cpu feature 7ee3b5d hw/i386/vmport: Allow QTest use without crashing c79f240 target/i386: fix fisttpl, fisttpll handling of out-of-range values 7e360a8 target/i386: fix fbstp handling of out-of-range values 9f11ae8 target/i386: fix fbstp handling of negative zero 59ce66a target/i386: fix fxam handling of invalid encodings 68d8ffc target/i386: fix floating-point load-constant rounding 8d4006e hw/elf_ops: Do not ignore write failures when loading ELF 3a3c475 disas: Let disas::read_memory() handler return EIO on error 6bfda5f exec: Propagate cpu_memory_rw_debug() error 63d6911 exec: Let address_space_read/write_cached() propagate MemTxResult 85733ec target/i386: fix fscale handling of rounding precision 22d5344 target/i386: fix fscale handling of infinite exponents d9e4f5b target/i386: fix fscale handling of invalid exponent encodings 23a2034 target/i386: fix fscale handling of signaling NaN e197304 target/i386: implement special cases for fxtract 3aed295 megasas: use unsigned type for positive numeric fields ca61e75 megasas: avoid NULL pointer dereference dc1d959 megasas: use unsigned type for reply_queue_head and check index 7af8d9c i386/kvm: fix a use-after-free when vcpu plug/unplug e79558f hax: Dynamic allocate vcpu state structure 04d77de cpus: Fix botched configure_icount() error API violation fix 538a83f qom/container: remove .instance_size initializer from container_info c49bd3d qom/object: pass (Object *) to object_initialize_with_type() 3e9db3f qom/object: simplify type_initialize_interface() f76ef9d qom/object: factor out the initialization of hash table of properties 28278b9 qom: remove index from object_resolve_abs_path() db672e1 accel: Move Xen accelerator code under accel/xen/ a46ccc2 hw/i386/vmport: Assert vmport initialized before registering commands fc3c919 hw/i386/vmport: Add support for CMD_GETHZ 806f934 i386/cpu: Store LAPIC bus frequency in CPU structure 7798d77 hw/i386/vmport: Allow x2apic without IR f87ad26 hw/i386/vmport: Add support for CMD_GET_VCPU_INFO bbd5878 hw/i386/vmport: Add support for CMD_GETBIOSUUID bb5bcad hw/i386/vmport: Define enum for all commands 2253a04 hw/i386/vmport: Introduce vmport.h e88c358 hw/i386/vmport: Report vmware-vmx-type in CMD_GETVERSION 797442e hw/i386/vmport: Introduce vmware-vmx-version property 48cd9ce hw/i386/vmport: Set EAX to -1 on failed and unsupported commands 562b30f hw/i386/vmport: Propagate IOPort read to vCPU EAX register 1232e46 hw/i386/vmport: Add device properties d7df941 hw/i386/vmport: Add reference to VMware open-vm-tools 45adc60 target/i386: fix phadd* with identical destination and source register 5350585 target/i386: Fix the CPUID leaf CPUID_Fn80000008 3fbb68b vmbus: add infrastructure to save/load vmbus requests df61787 i386: Hyper-V VMBus ACPI DSDT entry a018f5e i386:pc: whitelist dynamic vmbus-bridge 9ebd496 vmbus: vmbus implementation a547e98 vmbus: add vmbus protocol definitions a7a963e hyperv: expose API to determine if synic is enabled 1dbe145 Makefile: Let the 'help' target list the helper targets e144bcf io/task: Move 'qom/object.h' header to source 359ba29 qom/object: Move Object typedef to 'qemu/typedefs.h' 9533078 target/i386: Fix OUTL debug output c0b28e6 qom/object: Fix object_child_foreach_recursive() return value 386d522 icount: fix shift=auto for record/replay a0f1875 numa: prevent usage of -M memory-backend and -numa memdev at the same time 561b3f3 vl.c: run preconfig loop before creating default RAM backend 0eeaed9 run-coverity-scan: support --update-tools-only --docker c96d7fe run-coverity-scan: download tools outside the container 3e647fb run-coverity-scan: use --no-update-tools in docker run 8d61426 run-coverity-scan: add --no-update-tools option d4fa635 run-coverity-scan: use docker.py 9e4f18d run-coverity-scan: get Coverity token and email from special git config section 4a5b4f8 docker.py/build: support binary files in --extra-files ed203cb docker.py/build: support -t and -f arguments === OUTPUT BEGIN === 1/115 Checking commit ed203cb565bc (docker.py/build: support -t and -f arguments) 2/115 Checking commit 4a5b4f82cf06 (docker.py/build: support binary files in --extra-files) 3/115 Checking commit 9e4f18d15693 (run-coverity-scan: get Coverity token and email from special git config section) 4/115 Checking commit d4fa6352af61 (run-coverity-scan: use docker.py) 5/115 Checking commit 8d61426da8be (run-coverity-scan: add --no-update-tools option) 6/115 Checking commit 3e647fb8c66b (run-coverity-scan: use --no-update-tools in docker run) 7/115 Checking commit c96d7fea1d40 (run-coverity-scan: download tools outside the container) 8/115 Checking commit 0eeaed9046f6 (run-coverity-scan: support --update-tools-only --docker) 9/115 Checking commit 561b3f3dbb49 (vl.c: run preconfig loop before creating default RAM backend) 10/115 Checking commit a0f187582a43 (numa: prevent usage of -M memory-backend and -numa memdev at the same time) 11/115 Checking commit 386d52235555 (icount: fix shift=auto for record/replay) 12/115 Checking commit c0b28e67ae8f (qom/object: Fix object_child_foreach_recursive() return value) 13/115 Checking commit 953307832f9e (target/i386: Fix OUTL debug output) 14/115 Checking commit 359ba29d91a1 (qom/object: Move Object typedef to 'qemu/typedefs.h') 15/115 Checking commit e144bcf27354 (io/task: Move 'qom/object.h' header to source) 16/115 Checking commit 1dbe1451b554 (Makefile: Let the 'help' target list the helper targets) 17/115 Checking commit a7a963e82034 (hyperv: expose API to determine if synic is enabled) 18/115 Checking commit a547e987c3ee (vmbus: add vmbus protocol definitions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 222 lines checked Patch 18/115 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 19/115 Checking commit 9ebd496e40c2 (vmbus: vmbus implementation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #74: new file mode 100644 total: 0 errors, 1 warnings, 2967 lines checked Patch 19/115 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 20/115 Checking commit a018f5e83e64 (i386:pc: whitelist dynamic vmbus-bridge) 21/115 Checking commit df6178722e55 (i386: Hyper-V VMBus ACPI DSDT entry) 22/115 Checking commit 3fbb68b67d01 (vmbus: add infrastructure to save/load vmbus requests) 23/115 Checking commit 535058507f56 (target/i386: Fix the CPUID leaf CPUID_Fn80000008) 24/115 Checking commit 45adc6000beb (target/i386: fix phadd* with identical destination and source register) 25/115 Checking commit d7df941d2c4b (hw/i386/vmport: Add reference to VMware open-vm-tools) 26/115 Checking commit 1232e46cf2cd (hw/i386/vmport: Add device properties) 27/115 Checking commit 562b30f77b70 (hw/i386/vmport: Propagate IOPort read to vCPU EAX register) 28/115 Checking commit 48cd9ce82c8e (hw/i386/vmport: Set EAX to -1 on failed and unsupported commands) 29/115 Checking commit 797442eea681 (hw/i386/vmport: Introduce vmware-vmx-version property) 30/115 Checking commit e88c3580bd95 (hw/i386/vmport: Report vmware-vmx-type in CMD_GETVERSION) 31/115 Checking commit 2253a0464ff4 (hw/i386/vmport: Introduce vmport.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #69: deleted file mode 100644 total: 0 errors, 1 warnings, 52 lines checked Patch 31/115 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 32/115 Checking commit bb5bcadd8302 (hw/i386/vmport: Define enum for all commands) 33/115 Checking commit bbd587829c2c (hw/i386/vmport: Add support for CMD_GETBIOSUUID) 34/115 Checking commit f87ad2639f79 (hw/i386/vmport: Add support for CMD_GET_VCPU_INFO) 35/115 Checking commit 7798d770a7ad (hw/i386/vmport: Allow x2apic without IR) 36/115 Checking commit 806f934798ef (i386/cpu: Store LAPIC bus frequency in CPU structure) 37/115 Checking commit fc3c919c32df (hw/i386/vmport: Add support for CMD_GETHZ) 38/115 Checking commit a46ccc2d17e3 (hw/i386/vmport: Assert vmport initialized before registering commands) 39/115 Checking commit db672e10246c (accel: Move Xen accelerator code under accel/xen/) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 241 lines checked Patch 39/115 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 40/115 Checking commit 28278b9fb847 (qom: remove index from object_resolve_abs_path()) 41/115 Checking commit f76ef9d0f6dd (qom/object: factor out the initialization of hash table of properties) 42/115 Checking commit 3e9db3fc4df1 (qom/object: simplify type_initialize_interface()) 43/115 Checking commit c49bd3d36a29 (qom/object: pass (Object *) to object_initialize_with_type()) WARNING: line over 80 characters #24: FILE: qom/object.c:497: +static void object_initialize_with_type(Object *obj, size_t size, TypeImpl *type) total: 0 errors, 1 warnings, 11 lines checked Patch 43/115 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 44/115 Checking commit 538a83f883df (qom/container: remove .instance_size initializer from container_info) 45/115 Checking commit 04d77deecb37 (cpus: Fix botched configure_icount() error API violation fix) 46/115 Checking commit e79558f9f424 (hax: Dynamic allocate vcpu state structure) WARNING: line over 80 characters #51: FILE: target/i386/hax-all.c:249: + fprintf(stderr, "Maximum VCPU number QEMU supported is %d\n", HAX_MAX_VCPU); total: 0 errors, 1 warnings, 91 lines checked Patch 46/115 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 47/115 Checking commit 7af8d9ce700a (i386/kvm: fix a use-after-free when vcpu plug/unplug) 48/115 Checking commit dc1d959c2a13 (megasas: use unsigned type for reply_queue_head and check index) 49/115 Checking commit ca61e75559d9 (megasas: avoid NULL pointer dereference) 50/115 Checking commit 3aed295ae3fd (megasas: use unsigned type for positive numeric fields) 51/115 Checking commit e1973044bdf8 (target/i386: implement special cases for fxtract) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #58: new file mode 100644 ERROR: Use of volatile is usually wrong, please add a comment #73: FILE: tests/tcg/i386/test-i386-fxtract.c:11: +volatile union u ld_pseudo_m16382 = { .s = { UINT64_C(1) << 63, 0 } }; ERROR: Use of volatile is usually wrong, please add a comment #74: FILE: tests/tcg/i386/test-i386-fxtract.c:12: +volatile union u ld_invalid_1 = { .s = { 1, 1234 } }; ERROR: Use of volatile is usually wrong, please add a comment #75: FILE: tests/tcg/i386/test-i386-fxtract.c:13: +volatile union u ld_invalid_2 = { .s = { 0, 1234 } }; ERROR: Use of volatile is usually wrong, please add a comment #76: FILE: tests/tcg/i386/test-i386-fxtract.c:14: +volatile union u ld_invalid_3 = { .s = { 0, 0x7fff } }; ERROR: Use of volatile is usually wrong, please add a comment #77: FILE: tests/tcg/i386/test-i386-fxtract.c:15: +volatile union u ld_invalid_4 = { .s = { (UINT64_C(1) << 63) - 1, 0x7fff } }; ERROR: Use of volatile is usually wrong, please add a comment #79: FILE: tests/tcg/i386/test-i386-fxtract.c:17: +volatile long double ld_sig, ld_exp; ERROR: spaces required around that '-' (ctx:VxV) #142: FILE: tests/tcg/i386/test-i386-fxtract.c:80: + "0" (0x1p-16445L)); ^ total: 7 errors, 1 warnings, 154 lines checked Patch 51/115 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 52/115 Checking commit 23a20346b53f (target/i386: fix fscale handling of signaling NaN) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #32: new file mode 100644 ERROR: Use of volatile is usually wrong, please add a comment #47: FILE: tests/tcg/i386/test-i386-fscale.c:11: +volatile long double ld_res; total: 1 errors, 1 warnings, 47 lines checked Patch 52/115 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 53/115 Checking commit d9e4f5b12c80 (target/i386: fix fscale handling of invalid exponent encodings) ERROR: Use of volatile is usually wrong, please add a comment #42: FILE: tests/tcg/i386/test-i386-fscale.c:11: +volatile union u ld_invalid_1 = { .s = { 1, 1234 } }; ERROR: Use of volatile is usually wrong, please add a comment #43: FILE: tests/tcg/i386/test-i386-fscale.c:12: +volatile union u ld_invalid_2 = { .s = { 0, 1234 } }; ERROR: Use of volatile is usually wrong, please add a comment #44: FILE: tests/tcg/i386/test-i386-fscale.c:13: +volatile union u ld_invalid_3 = { .s = { 0, 0x7fff } }; ERROR: Use of volatile is usually wrong, please add a comment #45: FILE: tests/tcg/i386/test-i386-fscale.c:14: +volatile union u ld_invalid_4 = { .s = { (UINT64_C(1) << 63) - 1, 0x7fff } }; total: 4 errors, 0 warnings, 51 lines checked Patch 53/115 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 54/115 Checking commit 22d5344df5fa (target/i386: fix fscale handling of infinite exponents) 55/115 Checking commit 85733ec01504 (target/i386: fix fscale handling of rounding precision) ERROR: Use of volatile is usually wrong, please add a comment #43: FILE: tests/tcg/i386/test-i386-fscale.c:11: +volatile long double ld_third = 1.0L / 3.0L; ERROR: Use of volatile is usually wrong, please add a comment #44: FILE: tests/tcg/i386/test-i386-fscale.c:12: +volatile long double ld_four_thirds = 4.0L / 3.0L; total: 2 errors, 0 warnings, 34 lines checked Patch 55/115 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 56/115 Checking commit 63d6911369e9 (exec: Let address_space_read/write_cached() propagate MemTxResult) 57/115 Checking commit 6bfda5fdb0a5 (exec: Propagate cpu_memory_rw_debug() error) 58/115 Checking commit 3a3c475947e2 (disas: Let disas::read_memory() handler return EIO on error) 59/115 Checking commit 8d4006e2c26f (hw/elf_ops: Do not ignore write failures when loading ELF) 60/115 Checking commit 68d8ffcd5bdb (target/i386: fix floating-point load-constant rounding) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #110: new file mode 100644 ERROR: Use of volatile is usually wrong, please add a comment #120: FILE: tests/tcg/i386/test-i386-fldcst.c:6: +volatile long double ld_res; ERROR: spaces required around that '+' (ctx:VxV) #132: FILE: tests/tcg/i386/test-i386-fldcst.c:18: + if (ld_res != 0x3.5269e12f346e2bf8p+0L) { ^ ERROR: spaces required around that '+' (ctx:VxV) #141: FILE: tests/tcg/i386/test-i386-fldcst.c:27: + if (ld_res != 0x3.5269e12f346e2bf8p+0L) { ^ ERROR: spaces required around that '+' (ctx:VxV) #150: FILE: tests/tcg/i386/test-i386-fldcst.c:36: + if (ld_res != 0x3.5269e12f346e2bf8p+0L) { ^ ERROR: spaces required around that '+' (ctx:VxV) #159: FILE: tests/tcg/i386/test-i386-fldcst.c:45: + if (ld_res != 0x3.5269e12f346e2bfcp+0L) { ^ ERROR: spaces required around that '+' (ctx:VxV) #169: FILE: tests/tcg/i386/test-i386-fldcst.c:55: + if (ld_res != 0x1.71547652b82fe178p+0L) { ^ ERROR: spaces required around that '+' (ctx:VxV) #178: FILE: tests/tcg/i386/test-i386-fldcst.c:64: + if (ld_res != 0x1.71547652b82fe176p+0L) { ^ ERROR: spaces required around that '+' (ctx:VxV) #187: FILE: tests/tcg/i386/test-i386-fldcst.c:73: + if (ld_res != 0x1.71547652b82fe176p+0L) { ^ ERROR: spaces required around that '+' (ctx:VxV) #196: FILE: tests/tcg/i386/test-i386-fldcst.c:82: + if (ld_res != 0x1.71547652b82fe178p+0L) { ^ ERROR: spaces required around that '+' (ctx:VxV) #206: FILE: tests/tcg/i386/test-i386-fldcst.c:92: + if (ld_res != 0x3.243f6a8885a308d4p+0L) { ^ ERROR: spaces required around that '+' (ctx:VxV) #215: FILE: tests/tcg/i386/test-i386-fldcst.c:101: + if (ld_res != 0x3.243f6a8885a308dp+0L) { ^ ERROR: spaces required around that '+' (ctx:VxV) #224: FILE: tests/tcg/i386/test-i386-fldcst.c:110: + if (ld_res != 0x3.243f6a8885a308dp+0L) { ^ ERROR: spaces required around that '+' (ctx:VxV) #233: FILE: tests/tcg/i386/test-i386-fldcst.c:119: + if (ld_res != 0x3.243f6a8885a308d4p+0L) { ^ ERROR: spaces required around that '-' (ctx:VxV) #243: FILE: tests/tcg/i386/test-i386-fldcst.c:129: + if (ld_res != 0x4.d104d427de7fbcc8p-4L) { ^ ERROR: spaces required around that '-' (ctx:VxV) #252: FILE: tests/tcg/i386/test-i386-fldcst.c:138: + if (ld_res != 0x4.d104d427de7fbccp-4L) { ^ ERROR: spaces required around that '-' (ctx:VxV) #261: FILE: tests/tcg/i386/test-i386-fldcst.c:147: + if (ld_res != 0x4.d104d427de7fbccp-4L) { ^ ERROR: spaces required around that '-' (ctx:VxV) #270: FILE: tests/tcg/i386/test-i386-fldcst.c:156: + if (ld_res != 0x4.d104d427de7fbcc8p-4L) { ^ ERROR: spaces required around that '-' (ctx:VxV) #280: FILE: tests/tcg/i386/test-i386-fldcst.c:166: + if (ld_res != 0xb.17217f7d1cf79acp-4L) { ^ ERROR: spaces required around that '-' (ctx:VxV) #289: FILE: tests/tcg/i386/test-i386-fldcst.c:175: + if (ld_res != 0xb.17217f7d1cf79abp-4L) { ^ ERROR: spaces required around that '-' (ctx:VxV) #298: FILE: tests/tcg/i386/test-i386-fldcst.c:184: + if (ld_res != 0xb.17217f7d1cf79abp-4L) { ^ ERROR: spaces required around that '-' (ctx:VxV) #307: FILE: tests/tcg/i386/test-i386-fldcst.c:193: + if (ld_res != 0xb.17217f7d1cf79acp-4L) { ^ total: 21 errors, 1 warnings, 283 lines checked Patch 60/115 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 61/115 Checking commit 59ce66a8ea73 (target/i386: fix fxam handling of invalid encodings) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 ERROR: Use of volatile is usually wrong, please add a comment #56: FILE: tests/tcg/i386/test-i386-fxam.c:11: +volatile union u ld_pseudo_m16382 = { .s = { UINT64_C(1) << 63, 0 } }; ERROR: Use of volatile is usually wrong, please add a comment #57: FILE: tests/tcg/i386/test-i386-fxam.c:12: +volatile union u ld_pseudo_nm16382 = { .s = { UINT64_C(1) << 63, 0x8000 } }; ERROR: Use of volatile is usually wrong, please add a comment #58: FILE: tests/tcg/i386/test-i386-fxam.c:13: +volatile union u ld_invalid_1 = { .s = { 1, 1234 } }; ERROR: Use of volatile is usually wrong, please add a comment #59: FILE: tests/tcg/i386/test-i386-fxam.c:14: +volatile union u ld_invalid_2 = { .s = { 0, 1234 } }; ERROR: Use of volatile is usually wrong, please add a comment #60: FILE: tests/tcg/i386/test-i386-fxam.c:15: +volatile union u ld_invalid_3 = { .s = { 0, 0x7fff } }; ERROR: Use of volatile is usually wrong, please add a comment #61: FILE: tests/tcg/i386/test-i386-fxam.c:16: +volatile union u ld_invalid_4 = { .s = { (UINT64_C(1) << 63) - 1, 0x7fff } }; ERROR: Use of volatile is usually wrong, please add a comment #62: FILE: tests/tcg/i386/test-i386-fxam.c:17: +volatile union u ld_invalid_n1 = { .s = { 1, 0x8123 } }; ERROR: Use of volatile is usually wrong, please add a comment #63: FILE: tests/tcg/i386/test-i386-fxam.c:18: +volatile union u ld_invalid_n2 = { .s = { 0, 0x8123 } }; ERROR: Use of volatile is usually wrong, please add a comment #64: FILE: tests/tcg/i386/test-i386-fxam.c:19: +volatile union u ld_invalid_n3 = { .s = { 0, 0xffff } }; ERROR: Use of volatile is usually wrong, please add a comment #65: FILE: tests/tcg/i386/test-i386-fxam.c:20: +volatile union u ld_invalid_n4 = { .s = { (UINT64_C(1) << 63) - 1, 0xffff } }; ERROR: spaces required around that '-' (ctx:VxV) #127: FILE: tests/tcg/i386/test-i386-fxam.c:82: + __asm__ volatile ("fxam\nfnstsw" : "=a" (sw) : "t" (0x1p-16445L)); ^ ERROR: spaces required around that '-' (ctx:VxV) #132: FILE: tests/tcg/i386/test-i386-fxam.c:87: + __asm__ volatile ("fxam\nfnstsw" : "=a" (sw) : "t" (-0x1p-16445L)); ^ total: 12 errors, 1 warnings, 159 lines checked Patch 61/115 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 62/115 Checking commit 9f11ae8877f2 (target/i386: fix fbstp handling of negative zero) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #37: new file mode 100644 total: 0 errors, 1 warnings, 40 lines checked Patch 62/115 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 63/115 Checking commit 7e360a8876fe (target/i386: fix fbstp handling of out-of-range values) ERROR: Use of volatile is usually wrong, please add a comment #57: FILE: tests/tcg/i386/test-i386-fbstp.c:12: +volatile union u ld_invalid_1 = { .s = { 1, 1234 } }; ERROR: Use of volatile is usually wrong, please add a comment #58: FILE: tests/tcg/i386/test-i386-fbstp.c:13: +volatile union u ld_invalid_2 = { .s = { 0, 1234 } }; ERROR: Use of volatile is usually wrong, please add a comment #59: FILE: tests/tcg/i386/test-i386-fbstp.c:14: +volatile union u ld_invalid_3 = { .s = { 0, 0x7fff } }; ERROR: Use of volatile is usually wrong, please add a comment #60: FILE: tests/tcg/i386/test-i386-fbstp.c:15: +volatile union u ld_invalid_4 = { .s = { (UINT64_C(1) << 63) - 1, 0x7fff } }; total: 4 errors, 0 warnings, 144 lines checked Patch 63/115 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 64/115 Checking commit c79f240a3d83 (target/i386: fix fisttpl, fisttpll handling of out-of-range values) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #66: new file mode 100644 ERROR: Use of volatile is usually wrong, please add a comment #82: FILE: tests/tcg/i386/test-i386-fisttp.c:12: +volatile union u ld_invalid_1 = { .s = { 1, 1234 } }; total: 1 errors, 1 warnings, 138 lines checked Patch 64/115 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 65/115 Checking commit 7ee3b5d1c152 (hw/i386/vmport: Allow QTest use without crashing) 66/115 Checking commit dd325815af06 (x86/cpu: Enable AVX512_VP2INTERSECT cpu feature) 67/115 Checking commit 2b7dab66301d (vfio/pci: Use kvm_irqchip_add_irqfd_notifier_gsi() for irqfds) 68/115 Checking commit 1ead9654de7d (KVM: Pass EventNotifier into kvm_irqchip_assign_irqfd) 69/115 Checking commit d0110c612071 (KVM: Kick resamplefd for split kernel irqchip) 70/115 Checking commit 85f319e7f251 (chardev/char-socket: Properly make qio connections non blocking) 71/115 Checking commit 0abe63e4908f (tests: machine-none-test: Enable MicroBlaze testing) 72/115 Checking commit 06644d9db286 (hw/i386/amd_iommu: Fix the reserved bits definition of IOMMU commands) 73/115 Checking commit c130d2b31ab2 (replay: implement fair mutex) 74/115 Checking commit f21430a7fd25 (i386: Remove unused define's from hax and hvf) 75/115 Checking commit 6aa0a6817b14 (target/i386: define a new MSR based feature word - FEAT_PERF_CAPABILITIES) 76/115 Checking commit a3aaf5e4e5a6 (util/oslib: Returns the real thread identifier on FreeBSD and NetBSD) 77/115 Checking commit 3f5bb0f0819a (memory: Make 'info mtree' not display disabled regions by default) 78/115 Checking commit 98e8ed2cf4c1 (qemu/thread: Mark qemu_thread_exit() with 'noreturn' attribute) 79/115 Checking commit 3bd81dbdd79f (configure: Do not ignore malloc value) 80/115 Checking commit f843bd2eae6d (exec: set map length to zero when returning NULL) 81/115 Checking commit 136df11a66e3 (target/i386: fix IEEE x87 floating-point exception raising) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #485: new file mode 100644 ERROR: Use of volatile is usually wrong, please add a comment #501: FILE: tests/tcg/i386/test-i386-fp-exceptions.c:12: +volatile float f_res; ERROR: Use of volatile is usually wrong, please add a comment #502: FILE: tests/tcg/i386/test-i386-fp-exceptions.c:13: +volatile double d_res; ERROR: Use of volatile is usually wrong, please add a comment #503: FILE: tests/tcg/i386/test-i386-fp-exceptions.c:14: +volatile long double ld_res; ERROR: Use of volatile is usually wrong, please add a comment #504: FILE: tests/tcg/i386/test-i386-fp-exceptions.c:15: +volatile long double ld_res2; ERROR: Use of volatile is usually wrong, please add a comment #506: FILE: tests/tcg/i386/test-i386-fp-exceptions.c:17: +volatile union u ld_invalid_1 = { .s = { 1, 1234 } }; ERROR: Use of volatile is usually wrong, please add a comment #507: FILE: tests/tcg/i386/test-i386-fp-exceptions.c:18: +volatile float f_snan = __builtin_nansf(""); ERROR: Use of volatile is usually wrong, please add a comment #508: FILE: tests/tcg/i386/test-i386-fp-exceptions.c:19: +volatile double d_snan = __builtin_nans(""); ERROR: Use of volatile is usually wrong, please add a comment #509: FILE: tests/tcg/i386/test-i386-fp-exceptions.c:20: +volatile long double ld_third = 1.0L / 3.0L; ERROR: Use of volatile is usually wrong, please add a comment #510: FILE: tests/tcg/i386/test-i386-fp-exceptions.c:21: +volatile long double ld_snan = __builtin_nansl(""); ERROR: Use of volatile is usually wrong, please add a comment #511: FILE: tests/tcg/i386/test-i386-fp-exceptions.c:22: +volatile long double ld_nan = __builtin_nanl(""); ERROR: Use of volatile is usually wrong, please add a comment #512: FILE: tests/tcg/i386/test-i386-fp-exceptions.c:23: +volatile long double ld_inf = __builtin_infl(); ERROR: Use of volatile is usually wrong, please add a comment #513: FILE: tests/tcg/i386/test-i386-fp-exceptions.c:24: +volatile long double ld_ninf = -__builtin_infl(); ERROR: Use of volatile is usually wrong, please add a comment #514: FILE: tests/tcg/i386/test-i386-fp-exceptions.c:25: +volatile long double ld_one = 1.0L; ERROR: Use of volatile is usually wrong, please add a comment #515: FILE: tests/tcg/i386/test-i386-fp-exceptions.c:26: +volatile long double ld_zero = 0.0L; ERROR: Use of volatile is usually wrong, please add a comment #516: FILE: tests/tcg/i386/test-i386-fp-exceptions.c:27: +volatile long double ld_nzero = -0.0L; ERROR: Use of volatile is usually wrong, please add a comment #517: FILE: tests/tcg/i386/test-i386-fp-exceptions.c:28: +volatile long double ld_min = LDBL_MIN; ERROR: Use of volatile is usually wrong, please add a comment #518: FILE: tests/tcg/i386/test-i386-fp-exceptions.c:29: +volatile long double ld_max = LDBL_MAX; ERROR: Use of volatile is usually wrong, please add a comment #519: FILE: tests/tcg/i386/test-i386-fp-exceptions.c:30: +volatile long double ld_nmax = -LDBL_MAX; total: 18 errors, 1 warnings, 1252 lines checked Patch 81/115 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 82/115 Checking commit f9bd95ecf731 (target/i386: correct fix for pcmpxstrx substring search) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #105: new file mode 100644 total: 0 errors, 1 warnings, 54 lines checked Patch 82/115 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 83/115 Checking commit acb8d158c8e6 (sysemu/accel: Restrict machine methods to system-mode) 84/115 Checking commit 3b8e276cc23c (sysemu/tcg: Only declare tcg_allowed when TCG is available) 85/115 Checking commit 238000a0d14a (sysemu/hvf: Only declare hvf_allowed when HVF is available) 86/115 Checking commit 709b437b9793 (target/ppc: Restrict PPCVirtualHypervisorClass to system-mode) 87/115 Checking commit 7e1a49323f54 (i386: hvf: Move HVFState definition into hvf) 88/115 Checking commit b587a1b3d465 (i386: hvf: Drop useless declarations in sysemu) 89/115 Checking commit c4d282b6e889 (i386: hvf: Drop unused variable) 90/115 Checking commit ddb005dacbe6 (i386: hvf: Use ins_len to advance IP) 91/115 Checking commit ed88ce7c455e (i386: hvf: Use IP from CPUX86State) ERROR: unnecessary whitespace before a quoted newline #447: FILE: target/i386/hvf/x86_emu.c:1470: + printf("Unimplemented handler (%llx) for %d (%x %x) \n", env->eip, total: 1 errors, 0 warnings, 403 lines checked Patch 91/115 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 92/115 Checking commit e1de961f37f8 (i386: hvf: Drop fetch_rip from HVFX86EmulatorState) 93/115 Checking commit 014172380927 (i386: hvf: Drop rflags from HVFX86EmulatorState) 94/115 Checking commit e978983f7245 (i386: hvf: Drop copy of RFLAGS defines) 95/115 Checking commit df05641db746 (i386: hvf: Drop regs in HVFX86EmulatorState) 96/115 Checking commit 20208b4ea9b2 (i386: hvf: Move lazy_flags into CPUX86State) 97/115 Checking commit b52a4bf0b053 (i386: hvf: Move mmio_buf into CPUX86State) 98/115 Checking commit 93262a0ad3a1 (i386: hvf: Drop HVFX86EmulatorState) 99/115 Checking commit 5ec6d66e0735 (xen: fix build without pci passthrough) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #136: new file mode 100644 total: 0 errors, 1 warnings, 98 lines checked Patch 99/115 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 100/115 Checking commit b8dc835d0135 (target/i386: sev: Remove unused QSevGuestInfoClass) 101/115 Checking commit 4902392cbf95 (target/i386: sev: Move local structure definitions into .c file) 102/115 Checking commit 56fe4d8d689c (target/i386: sev: Rename QSevGuestInfo) 103/115 Checking commit 560d42bf0947 (target/i386: sev: Embed SEVState in SevGuestState) 104/115 Checking commit 832d4593f6cb (target/i386: sev: Partial cleanup to sev_state global) 105/115 Checking commit c0fa65326d38 (target/i386: sev: Remove redundant cbitpos and reduced_phys_bits fields) 106/115 Checking commit ef7e4eba2d42 (target/i386: sev: Remove redundant policy field) 107/115 Checking commit 722d1df382df (target/i386: sev: Remove redundant handle field) 108/115 Checking commit 11943a666921 (target/i386: sev: Unify SEVState and SevGuestState) 109/115 Checking commit 79d4c74905c8 (checkpatch: reversed logic with acpi test checks) 110/115 Checking commit 598847535a01 (exec/memory: Remove unused MemoryRegionMmio type) 111/115 Checking commit b4bf922f7e8a (hw/usb: Move device-specific declarations to new 'hcd-musb.h' header) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #83: new file mode 100644 total: 0 errors, 1 warnings, 96 lines checked Patch 111/115 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 112/115 Checking commit 8cf1910b2046 (exec/cpu-common: Move MUSB specific typedefs to 'hw/usb/hcd-musb.h') 113/115 Checking commit 9da3214af6d1 (replay: fix replay shutdown for console mode) 114/115 Checking commit ed8ffece50a9 (stubs: move Xen stubs to accel/) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #24: rename from stubs/xen-hvm.c total: 0 errors, 1 warnings, 36 lines checked Patch 114/115 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 115/115 Checking commit b258374fbf01 (target/i386: Remove obsolete TODO file) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #17: deleted file mode 100644 total: 0 errors, 1 warnings, 0 lines checked Patch 115/115 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200611194449.31468-1-pbonz...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
