On 11/06/2020 11:09, Greg Kurz wrote: > From: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> > > Introduce a new ERRP_AUTO_PROPAGATE macro, to be used at start of > functions with an errp OUT parameter. > > It has three goals: > > 1. Fix issue with error_fatal and error_prepend/error_append_hint: user > can't see this additional information, because exit() happens in > error_setg earlier than information is added. [Reported by Greg Kurz] > > 2. Fix issue with error_abort and error_propagate: when we wrap > error_abort by local_err+error_propagate, the resulting coredump will > refer to error_propagate and not to the place where error happened. > (the macro itself doesn't fix the issue, but it allows us to [3.] drop > the local_err+error_propagate pattern, which will definitely fix the > issue) [Reported by Kevin Wolf] > > 3. Drop local_err+error_propagate pattern, which is used to workaround > void functions with errp parameter, when caller wants to know resulting > status. (Note: actually these functions could be merely updated to > return int error code). > > To achieve these goals, later patches will add invocations > of this macro at the start of functions with either use > error_prepend/error_append_hint (solving 1) or which use > local_err+error_propagate to check errors, switching those > functions to use *errp instead (solving 2 and 3). > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> > Reviewed-by: Paul Durrant <p...@xen.org> > Reviewed-by: Greg Kurz <gr...@kaod.org> > Reviewed-by: Eric Blake <ebl...@redhat.com> > Signed-off-by: Greg Kurz <gr...@kaod.org> > --- > include/qapi/error.h | 205 > ++++++++++++++++++++++++++++++++++++++++++-------- > 1 file changed, 173 insertions(+), 32 deletions(-)
Reviewed-by: Laurent Vivier <lviv...@redhat.com>
