On 6/9/20 9:02 AM, Peter Maydell wrote: > +#define DO_NARROW_3D(INSN, OP, NARROWTYPE, EXTOP) \ > + static bool trans_##INSN##_3d(DisasContext *s, arg_3diff *a) \ > + { \ > + NeonGenTwo64OpFn *addfn[] = { \ > + gen_helper_neon_##OP##l_u16, \ > + gen_helper_neon_##OP##l_u32, \ > + tcg_gen_##OP##_i64, \ > + NULL, \ > + }; \ > + NeonGenNarrowFn *narrowfn[] = { \ > + gen_helper_neon_##NARROWTYPE##_high_u8, \ > + gen_helper_neon_##NARROWTYPE##_high_u16, \ > + EXTOP, \ > + NULL, \ > + }; \ > + return do_narrow_3d(s, a, addfn[a->size], narrowfn[a->size]); \ > + }
Missing const again. Otherwise, Reviewed-by: Richard Henderson <richard.hender...@linaro.org> r~