On Mon, 8 Jun 2020 at 12:40, Leif Lindholm <l...@nuviainc.com> wrote: > > Move the id register initializations identical between the platforms in > this file into a standalone helper function, and change the cpu-specific > > The value of mmfr0 set for a57 and a53 violates the ARM architecture > reference manual, but matches the values set in actual hardware r1p0 a57 > and r0p4 a53. The function sets the architectually correct value, and the > a57/a53 init functions override it after the fact.
...and pulling out the ID register value settings into a common function is definitely not something we want to do. Any new CPU should set all the ID register values and we want to be able to easily compare those settings against the TRM. thanks -- PMM
