On Thu, Jun 04, 2020 at 15:18:02 +0200, Andrew Jones wrote: > > - drop the call from aarch64_max_initfn to aarch64_a57_initfn, and > > copy the relevant bits into the former for the !kvm case > > I don't have a strong preference here, but if the naming is what's > troublesome, then I'd think we're better off creating something like > an aarch64_aXX_initfn() function and then calling it from both a57 > and max, and anywhere else it fits.
Well, the naming isn't the only issue, although there looks like a certain amount of duplication could be deleted from a57/a53/a72 and also be used for max if there was a common initfn. But there's also things like: - a57_initfn explicitly setting kvm_target, then only being called from max_initfn for !kvm_enabled() - a57_initfn setting cpu->dtb_compatible to "arm,cortex-a57" - a57 initfn setting cpu->midr, max_initfn overwriting parts of it Best Regards, Leif
