Patchew URL: https://patchew.org/QEMU/20200604085441.103087-1-kbast...@mail.uni-paderborn.de/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200604085441.103087-1-kbast...@mail.uni-paderborn.de Subject: [PATCH v2 00/15] tests/tcg: Add TriCore tests Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20200602084151.480567-1-imamm...@redhat.com -> patchew/20200602084151.480567-1-imamm...@redhat.com * [new tag] patchew/20200604085441.103087-1-kbast...@mail.uni-paderborn.de -> patchew/20200604085441.103087-1-kbast...@mail.uni-paderborn.de * [new tag] patchew/20200604085533.7769-1-chen.zh...@intel.com -> patchew/20200604085533.7769-1-chen.zh...@intel.com * [new tag] patchew/20200604090830.33885-1-ppan...@redhat.com -> patchew/20200604090830.33885-1-ppan...@redhat.com Switched to a new branch 'test' adea249 tests/tcg/tricore: Add muls test ed03880 tests/tcg/tricore: Add msub test fd95aee tests/tcg/tricore: Add madd test 6cda27e tests/tcg/tricore: Add ftoi test e0d0d05 tests/tcg/tricore: Add fmul test f415da7 tests/tcg/tricore: Add fadd test 4e3bbcf tests/tcg/tricore: Add dvstep test cbb2a9b tests/tcg/tricore: Add clz test e7bf647 tests/tcg/tricore: Add bmerge test 2496174 tests/tcg/tricore: Add macros to create tests and first test 'abs' e409c6e tests/tcg/tricore: Add build infrastructure cfede30 hw/tricore: Add testdevice for tests in tests/tcg/ 6ce5ebb tests/tcg: Run timeout cmds using --foreground 674eec5 tests/tcg: Add docker_as and docker_ld cmds 2054d8f docker/tricore: Use stretch-slim as a base image === OUTPUT BEGIN === 1/15 Checking commit 2054d8f49a1e (docker/tricore: Use stretch-slim as a base image) 2/15 Checking commit 674eec5f42a0 (tests/tcg: Add docker_as and docker_ld cmds) 3/15 Checking commit 6ce5ebb80600 (tests/tcg: Run timeout cmds using --foreground) 4/15 Checking commit cfede3047604 (hw/tricore: Add testdevice for tests in tests/tcg/) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #55: new file mode 100644 total: 0 errors, 1 warnings, 148 lines checked Patch 4/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/15 Checking commit e409c6efd010 (tests/tcg/tricore: Add build infrastructure) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #13: new file mode 100644 total: 0 errors, 1 warnings, 77 lines checked Patch 5/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/15 Checking commit 2496174da493 (tests/tcg/tricore: Add macros to create tests and first test 'abs') WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #59: new file mode 100644 ERROR: Macros with multiple statements should be enclosed in a do - while loop #65: FILE: tests/tcg/tricore/macros.h:2: +#define LI(reg, val) \ + mov.u reg, lo:val; \ + movh DREG_TEMP_LI, up:val; \ + or reg, reg, DREG_TEMP_LI; \ + ERROR: spaces required around that ':' (ctx:VxV) #66: FILE: tests/tcg/tricore/macros.h:3: + mov.u reg, lo:val; \ ^ ERROR: spaces required around that ':' (ctx:VxV) #67: FILE: tests/tcg/tricore/macros.h:4: + movh DREG_TEMP_LI, up:val; \ ^ ERROR: spaces required around that '%' (ctx:WxV) #73: FILE: tests/tcg/tricore/macros.h:10: +#define DREG_RS1 %d0 ^ ERROR: Macros with complex values should be enclosed in parenthesis #73: FILE: tests/tcg/tricore/macros.h:10: +#define DREG_RS1 %d0 ERROR: spaces required around that '%' (ctx:WxV) #74: FILE: tests/tcg/tricore/macros.h:11: +#define DREG_CALC_RESULT %d1 ^ ERROR: Macros with complex values should be enclosed in parenthesis #74: FILE: tests/tcg/tricore/macros.h:11: +#define DREG_CALC_RESULT %d1 ERROR: spaces required around that '%' (ctx:WxV) #75: FILE: tests/tcg/tricore/macros.h:12: +#define DREG_TEMP_LI %d10 ^ ERROR: Macros with complex values should be enclosed in parenthesis #75: FILE: tests/tcg/tricore/macros.h:12: +#define DREG_TEMP_LI %d10 ERROR: spaces required around that '%' (ctx:WxV) #76: FILE: tests/tcg/tricore/macros.h:13: +#define DREG_TEMP %d11 ^ ERROR: Macros with complex values should be enclosed in parenthesis #76: FILE: tests/tcg/tricore/macros.h:13: +#define DREG_TEMP %d11 ERROR: spaces required around that '%' (ctx:WxV) #77: FILE: tests/tcg/tricore/macros.h:14: +#define DREG_TEST_NUM %d14 ^ ERROR: Macros with complex values should be enclosed in parenthesis #77: FILE: tests/tcg/tricore/macros.h:14: +#define DREG_TEST_NUM %d14 ERROR: spaces required around that '%' (ctx:WxV) #78: FILE: tests/tcg/tricore/macros.h:15: +#define DREG_CORRECT_RESULT %d15 ^ ERROR: Macros with complex values should be enclosed in parenthesis #78: FILE: tests/tcg/tricore/macros.h:15: +#define DREG_CORRECT_RESULT %d15 ERROR: spaces required around that '%' (ctx:WxV) #80: FILE: tests/tcg/tricore/macros.h:17: +#define DREG_DEV_ADDR %a15 ^ ERROR: Macros with complex values should be enclosed in parenthesis #80: FILE: tests/tcg/tricore/macros.h:17: +#define DREG_DEV_ADDR %a15 ERROR: Macros with multiple statements should be enclosed in a do - while loop #83: FILE: tests/tcg/tricore/macros.h:20: +#define TEST_CASE(num, testreg, correct, code...) \ +test_ ## num: \ + code; \ + LI(DREG_CORRECT_RESULT, correct) \ + mov DREG_TEST_NUM, num; \ + jne testreg, DREG_CORRECT_RESULT, fail \ + ERROR: spaces required around that ':' (ctx:VxE) #84: FILE: tests/tcg/tricore/macros.h:21: +test_ ## num: \ ^ WARNING: Block comments use a leading /* on a separate line #90: FILE: tests/tcg/tricore/macros.h:27: +/* Actual test case type ERROR: Macros with multiple statements should be enclosed in a do - while loop #102: FILE: tests/tcg/tricore/macros.h:39: +#define TEST_PASSFAIL \ + j pass; \ +fail: \ + LI(DREG_TEMP, TESTDEV_ADDR) \ + mov.a DREG_DEV_ADDR, DREG_TEMP; \ + st.w [DREG_DEV_ADDR], DREG_TEST_NUM;\ + debug; \ + j fail; \ +pass: \ + LI(DREG_TEMP, TESTDEV_ADDR) \ + mov.a DREG_DEV_ADDR, DREG_TEMP; \ + mov DREG_TEST_NUM, 0; \ + st.w [DREG_DEV_ADDR], DREG_TEST_NUM;\ + debug; \ + j pass; ERROR: space prohibited before open square bracket '[' #107: FILE: tests/tcg/tricore/macros.h:44: + st.w [DREG_DEV_ADDR], DREG_TEST_NUM;\ ERROR: space prohibited before open square bracket '[' #114: FILE: tests/tcg/tricore/macros.h:51: + st.w [DREG_DEV_ADDR], DREG_TEST_NUM;\ total: 22 errors, 2 warnings, 88 lines checked Patch 6/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/15 Checking commit e7bf647c2950 (tests/tcg/tricore: Add bmerge test) ERROR: spaces required around that '%' (ctx:WxV) #30: FILE: tests/tcg/tricore/macros.h:11: +#define DREG_RS2 %d1 ^ ERROR: Macros with complex values should be enclosed in parenthesis #30: FILE: tests/tcg/tricore/macros.h:11: +#define DREG_RS2 %d1 ERROR: spaces required around that '%' (ctx:WxV) #32: FILE: tests/tcg/tricore/macros.h:13: +#define DREG_CALC_PSW %d2 ^ ERROR: Macros with complex values should be enclosed in parenthesis #32: FILE: tests/tcg/tricore/macros.h:13: +#define DREG_CALC_PSW %d2 ERROR: spaces required around that '%' (ctx:WxV) #33: FILE: tests/tcg/tricore/macros.h:14: +#define DREG_CORRECT_PSW %d3 ^ ERROR: Macros with complex values should be enclosed in parenthesis #33: FILE: tests/tcg/tricore/macros.h:14: +#define DREG_CORRECT_PSW %d3 ERROR: spaces required around that ':' (ctx:VxE) #42: FILE: tests/tcg/tricore/macros.h:31: +test_ ## num: \ ^ WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #73: new file mode 100644 total: 7 errors, 1 warnings, 58 lines checked Patch 7/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/15 Checking commit cbb2a9b16fb4 (tests/tcg/tricore: Add clz test) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #23: new file mode 100644 total: 0 errors, 1 warnings, 16 lines checked Patch 8/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/15 Checking commit 4e3bbcf905f6 (tests/tcg/tricore: Add dvstep test) ERROR: spaces required around that '%' (ctx:WxV) #30: FILE: tests/tcg/tricore/macros.h:22: +#define EREG_RS1 %e6 ^ ERROR: Macros with complex values should be enclosed in parenthesis #30: FILE: tests/tcg/tricore/macros.h:22: +#define EREG_RS1 %e6 ERROR: spaces required around that '%' (ctx:WxV) #31: FILE: tests/tcg/tricore/macros.h:23: +#define EREG_RS1_LO %d6 ^ ERROR: Macros with complex values should be enclosed in parenthesis #31: FILE: tests/tcg/tricore/macros.h:23: +#define EREG_RS1_LO %d6 ERROR: spaces required around that '%' (ctx:WxV) #32: FILE: tests/tcg/tricore/macros.h:24: +#define EREG_RS1_HI %d7 ^ ERROR: Macros with complex values should be enclosed in parenthesis #32: FILE: tests/tcg/tricore/macros.h:24: +#define EREG_RS1_HI %d7 ERROR: spaces required around that '%' (ctx:WxV) #33: FILE: tests/tcg/tricore/macros.h:25: +#define EREG_RS2 %e8 ^ ERROR: Macros with complex values should be enclosed in parenthesis #33: FILE: tests/tcg/tricore/macros.h:25: +#define EREG_RS2 %e8 ERROR: spaces required around that '%' (ctx:WxV) #34: FILE: tests/tcg/tricore/macros.h:26: +#define EREG_RS2_LO %d8 ^ ERROR: Macros with complex values should be enclosed in parenthesis #34: FILE: tests/tcg/tricore/macros.h:26: +#define EREG_RS2_LO %d8 ERROR: spaces required around that '%' (ctx:WxV) #35: FILE: tests/tcg/tricore/macros.h:27: +#define EREG_RS2_HI %d9 ^ ERROR: Macros with complex values should be enclosed in parenthesis #35: FILE: tests/tcg/tricore/macros.h:27: +#define EREG_RS2_HI %d9 ERROR: spaces required around that '%' (ctx:WxV) #36: FILE: tests/tcg/tricore/macros.h:28: +#define EREG_CALC_RESULT %e8 ^ ERROR: Macros with complex values should be enclosed in parenthesis #36: FILE: tests/tcg/tricore/macros.h:28: +#define EREG_CALC_RESULT %e8 ERROR: spaces required around that '%' (ctx:WxV) #37: FILE: tests/tcg/tricore/macros.h:29: +#define EREG_CALC_RESULT_HI %d9 ^ ERROR: Macros with complex values should be enclosed in parenthesis #37: FILE: tests/tcg/tricore/macros.h:29: +#define EREG_CALC_RESULT_HI %d9 ERROR: spaces required around that '%' (ctx:WxV) #38: FILE: tests/tcg/tricore/macros.h:30: +#define EREG_CALC_RESULT_LO %d8 ^ ERROR: Macros with complex values should be enclosed in parenthesis #38: FILE: tests/tcg/tricore/macros.h:30: +#define EREG_CALC_RESULT_LO %d8 ERROR: spaces required around that '%' (ctx:WxV) #39: FILE: tests/tcg/tricore/macros.h:31: +#define EREG_CORRECT_RESULT_LO %d0 ^ ERROR: Macros with complex values should be enclosed in parenthesis #39: FILE: tests/tcg/tricore/macros.h:31: +#define EREG_CORRECT_RESULT_LO %d0 ERROR: spaces required around that '%' (ctx:WxV) #40: FILE: tests/tcg/tricore/macros.h:32: +#define EREG_CORRECT_RESULT_HI %d1 ^ ERROR: Macros with complex values should be enclosed in parenthesis #40: FILE: tests/tcg/tricore/macros.h:32: +#define EREG_CORRECT_RESULT_HI %d1 ERROR: spaces required around that ':' (ctx:VxE) #50: FILE: tests/tcg/tricore/macros.h:43: +test_ ## num: \ ^ WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #77: new file mode 100644 total: 23 errors, 1 warnings, 69 lines checked Patch 9/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/15 Checking commit f415da7548bc (tests/tcg/tricore: Add fadd test) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #23: new file mode 100644 total: 0 errors, 1 warnings, 23 lines checked Patch 10/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/15 Checking commit e0d0d05ca98d (tests/tcg/tricore: Add fmul test) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #23: new file mode 100644 total: 0 errors, 1 warnings, 15 lines checked Patch 11/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/15 Checking commit 6cda27e1216b (tests/tcg/tricore: Add ftoi test) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 30 lines checked Patch 12/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/15 Checking commit fd95aee92a6e (tests/tcg/tricore: Add madd test) ERROR: spaces required around that '%' (ctx:WxV) #30: FILE: tests/tcg/tricore/macros.h:12: +#define DREG_RS3 %d4 ^ ERROR: Macros with complex values should be enclosed in parenthesis #30: FILE: tests/tcg/tricore/macros.h:12: +#define DREG_RS3 %d4 WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #59: new file mode 100644 total: 2 errors, 1 warnings, 48 lines checked Patch 13/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/15 Checking commit ed038809a5e2 (tests/tcg/tricore: Add msub test) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #23: new file mode 100644 total: 0 errors, 1 warnings, 16 lines checked Patch 14/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/15 Checking commit adea249349c0 (tests/tcg/tricore: Add muls test) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #23: new file mode 100644 total: 0 errors, 1 warnings, 16 lines checked Patch 15/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200604085441.103087-1-kbast...@mail.uni-paderborn.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
