On 200603 1646, Thomas Huth wrote: > On 02/06/2020 15.40, Alexander Bulekov wrote: > > Thank you Darren. > > > > On 200602 1428, Darren Kenny wrote: > >> > >> Hi Alex, > >> > >> In general the series looks good, so: > >> > >> Reviewed-by: Darren Kenny <darren.ke...@oracle.com> > >> > >> But not sure how to handle the patchew output though, not sure if it is > >> really a concern or not, since do/while won't work that context. > >> > > > > Yes - I was not really sure how to deal with those failures, so I sent > > the patch anyway. Maybe someone else knows a workaround. > > -Alex > > Don't worry, the checkpatch script is known to generate false > warnings/errors in some cases. If you've got such a case, simply state > it as a reply to the mail from patchew, and then the message from > patchew can be simply ignored. > > By the way, I'm finally back to the state where I can pick up qtest > patches again (btw2, thanks for Stefan for picking up all the fuzzer > patches in the past months). So question: With your two patches here, > the patch from Philippe is not required anymore, right?
Hi Thomas, Yes - I think this series enables the same improvements as Philippe's patch. Thank you -Alex > Thanks, > Thomas > > >> On Friday, 2020-05-29 at 18:14:48 -04, Alexander Bulekov wrote: > >>> In the same vein as Philippe's patch: > >>> > >>> https://patchew.org/QEMU/20200528165303.1877-1-f4...@amsat.org/ > >>> > >>> This uses linker trickery to wrap calls to libqtest functions and > >>> directly call the corresponding read/write functions, rather than > >>> relying on the ASCII-serialized QTest protocol. > >>> > >>> v2: applies properly > >>> > >>> v3: add missing qtest_wrappers.c file and fix formatting in fuzz.c > >>> > >>> Alexander Bulekov (2): > >>> fuzz: skip QTest serialization > >>> fuzz: Add support for logging QTest commands > >>> > >>> tests/qtest/fuzz/Makefile.include | 21 +++ > >>> tests/qtest/fuzz/fuzz.c | 20 ++- > >>> tests/qtest/fuzz/fuzz.h | 3 + > >>> tests/qtest/fuzz/qtest_wrappers.c | 252 ++++++++++++++++++++++++++++++ > >>> 4 files changed, 295 insertions(+), 1 deletion(-) > >>> create mode 100644 tests/qtest/fuzz/qtest_wrappers.c > >>> > >>> -- > >>> 2.26.2 > > >
