Patchew URL: https://patchew.org/QEMU/20200529180025.169097-1-...@tribudubois.net/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200529180025.169097-1-...@tribudubois.net Subject: [PATCH] hw/net/imx_fec.c: Convert debug fprintf() to trace event Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu * [new tag] patchew/20200529180025.169097-1-...@tribudubois.net -> patchew/20200529180025.169097-1-...@tribudubois.net Switched to a new branch 'test' 7cbd4dc hw/net/imx_fec.c: Convert debug fprintf() to trace event === OUTPUT BEGIN === ERROR: code indent should never use tabs #268: FILE: hw/net/imx_fec.c:1091: +^Itrace_imx_fec_receive_len(addr, bd.length);$ ERROR: code indent should never use tabs #278: FILE: hw/net/imx_fec.c:1110: +^I trace_imx_fec_receive_last(bd.flags);$ ERROR: code indent should never use tabs #297: FILE: hw/net/imx_fec.c:1190: +^Itrace_imx_enet_receive_len(addr, bd.length);$ ERROR: code indent should never use tabs #307: FILE: hw/net/imx_fec.c:1227: +^I trace_imx_enet_receive_last(bd.flags);$ ERROR: Hex numbers must be prefixed with '0x' #326: FILE: hw/net/trace-events:417: +imx_fec_read_bd(uint64_t addr, int flags, int len, int data) "tx_bd %lx flags %04x len %d data %08x" ERROR: Hex numbers must be prefixed with '0x' #327: FILE: hw/net/trace-events:418: +imx_enet_read_bd(uint64_t addr, int flags, int len, int data, int options, int status) "tx_bd %lx flags %04x len %d data %08x option %04x status %04x" ERROR: Hex numbers must be prefixed with '0x' #334: FILE: hw/net/trace-events:425: +imx_fec_receive_last(int last) "rx frame flags %04x" ERROR: Hex numbers must be prefixed with '0x' #337: FILE: hw/net/trace-events:428: +imx_enet_receive_last(int last) "rx frame flags %04x" total: 8 errors, 0 warnings, 297 lines checked Commit 7cbd4dcade5a (hw/net/imx_fec.c: Convert debug fprintf() to trace event) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200529180025.169097-1-...@tribudubois.net/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
