On 5/14/20 7:53 AM, John Snow wrote: > In truth, if you don't do this, you'll just get a TypeError > exception. Now, you'll get an AssertionError. > > Is this tangibly better? No. > Does mypy complain less? Yes. > > Signed-off-by: John Snow <js...@redhat.com> > --- > python/qemu/lib/qmp.py | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/python/qemu/lib/qmp.py b/python/qemu/lib/qmp.py > index 5fb16f4b42..1aefc00c93 100644 > --- a/python/qemu/lib/qmp.py > +++ b/python/qemu/lib/qmp.py > @@ -132,6 +132,7 @@ def __negotiate_capabilities(self): > raise QMPCapabilitiesError > > def __json_read(self, only_event=False): > + assert self.__sockfile is not None > while True: > data = self.__sockfile.readline() > if not data: >
Acked-by: Philippe Mathieu-Daudé <phi...@redhat.com>
