On Mon, 25 May 2020 15:41:00 +0200
Gerd Hoffmann <kra...@redhat.com> wrote:
> Not useful for microvm and allows users to shot themself
s/shot/shoot/
> into the foot (make ram + mmio overlap).
also see my toher reply to previous version, parhaps we can drop some more
logic here
> Signed-off-by: Gerd Hoffmann <kra...@redhat.com>
Reviewed-by: Igor Mammedov <imamm...@redhat.com>
> ---
> hw/i386/microvm.c | 19 -------------------
> 1 file changed, 19 deletions(-)
>
> diff --git a/hw/i386/microvm.c b/hw/i386/microvm.c
> index 44c08f8a5ab0..4b6ec2bbe331 100644
> --- a/hw/i386/microvm.c
> +++ b/hw/i386/microvm.c
> @@ -173,25 +173,6 @@ static void microvm_memory_init(MicrovmMachineState *mms)
> ram_addr_t lowmem = 0x80000000; /* 2G */
> int i;
>
> - /*
> - * Handle the machine opt max-ram-below-4g. It is basically doing
> - * min(qemu limit, user limit).
> - */
> - if (!x86ms->max_ram_below_4g) {
> - x86ms->max_ram_below_4g = 4 * GiB;
> - }
> - if (lowmem > x86ms->max_ram_below_4g) {
> - lowmem = x86ms->max_ram_below_4g;
> - if (machine->ram_size - lowmem > lowmem &&
> - lowmem & (1 * GiB - 1)) {
> - warn_report("There is possibly poor performance as the ram size "
> - " (0x%" PRIx64 ") is more then twice the size of"
> - " max-ram-below-4g (%"PRIu64") and"
> - " max-ram-below-4g is not a multiple of 1G.",
> - (uint64_t)machine->ram_size,
> x86ms->max_ram_below_4g);
> - }
> - }
> -
> if (machine->ram_size > lowmem) {
> x86ms->above_4g_mem_size = machine->ram_size - lowmem;
> x86ms->below_4g_mem_size = lowmem;
