Peter Maydell <peter.mayd...@linaro.org> writes: > On Mon, 18 May 2020 at 06:04, Markus Armbruster <arm...@redhat.com> wrote: >> >> These devices are optional, and enabled by property "enable-bitband". >> armv7m_instance_init() creates them unconditionally, because the >> property has not been set then. armv7m_realize() realizes them only >> when the property is true. Works, although it leaves unrealized >> devices hanging around in the QOM composition tree. Affects machines >> microbit, mps2-an505, mps2-an521, musca-a, and musca-b1. >> >> Bury the unwanted devices by making armv7m_realize() unparent them. >> Visible in "info qom-tree"; here's the change for microbit: >> >> /machine (microbit-machine) >> /microbit.twi (microbit.i2c) >> /microbit.twi[0] (qemu:memory-region) >> /nrf51 (nrf51-soc) >> /armv6m (armv7m) >> /armv7m-container[0] (qemu:memory-region) >> - /bitband[0] (ARM,bitband-memory) >> - /bitband[0] (qemu:memory-region) >> - /bitband[1] (ARM,bitband-memory) >> - /bitband[0] (qemu:memory-region) >> /cpu (cortex-m0-arm-cpu) > > What does "bury" mean here? To me it implies "they still > exist but we've stuck them in a hole somewhere and covered > them up", but the qom-tree delta suggests we've actually > really deleted them?
We really delete them now. "They've been lying dead in the streets; give them a decent burial". Would you like me to s/Bury/Delete/?