Patchew URL: https://patchew.org/QEMU/20200520132003.9492-1-kra...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200520132003.9492-1-kra...@redhat.com Subject: [PATCH v3 00/22] microvm: add acpi support Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu * [new tag] patchew/20200520132003.9492-1-kra...@redhat.com -> patchew/20200520132003.9492-1-kra...@redhat.com Switched to a new branch 'test' 7280d50 acpi: flip default to off for microvm 0c46cb7 acpi: add per machine type acpi default 3932159 microvm/acpi: disable virtio-mmio cmdline hack 88c8990 microvm/acpi: use seabios with acpi=on 00de58b microvm/acpi: use GSI 16-23 for virtio f442b20 microvm/acpi: add acpi_dsdt_add_virtio() for x86 50bd765 microvm/acpi: add minimal acpi support b44d3ee2 microvm: make virtio irq base runtime configurable 8473717 microvm: use 2G split unconditionally 9a8690b x86: coldplug cpus 873496e acpi: move acpi_dsdt_add_power_button() to ged 570b71e acpi: ged: add x86 device variant. 42157e1 acpi: ged: add control regs 963229e acpi: ged: rename event memory region ffcb835 acpi: fadt: add hw-reduced sleep register support 628859e acpi: madt: skip pci override on pci-less systems. d7248a7 acpi: create acpi-common.c and move madt code 33254f5 acpi: make build_madt() more generic. 447375a seabios: update binaries to master snapshot f474461 seabios: update config & build rules 583a45c seabios: update submodule to master snapshot ce0b4a0 microvm: name qboot binary qboot.bin === OUTPUT BEGIN === 1/22 Checking commit ce0b4a0ec4ce (microvm: name qboot binary qboot.bin) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #36: rename from pc-bios/bios-microvm.bin total: 0 errors, 1 warnings, 35 lines checked Patch 1/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/22 Checking commit 583a45cbd0ff (seabios: update submodule to master snapshot) 3/22 Checking commit f474461987ec (seabios: update config & build rules) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #45: new file mode 100644 total: 0 errors, 1 warnings, 50 lines checked Patch 3/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/22 Checking commit 447375a74a06 (seabios: update binaries to master snapshot) 5/22 Checking commit 33254f57d62c (acpi: make build_madt() more generic.) 6/22 Checking commit d7248a7438fe (acpi: create acpi-common.c and move madt code) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #182: new file mode 100644 WARNING: Block comments use a leading /* on a separate line #187: FILE: hw/i386/acpi-common.c:1: +/* Support for generating ACPI tables and passing them to Guests WARNING: Block comments use a leading /* on a separate line #227: FILE: hw/i386/acpi-common.c:41: + /* ACPI spec says that LAPIC entry for non present ERROR: spaces required around that '<<' (ctx:VxV) #301: FILE: hw/i386/acpi-common.c:115: +#define ACPI_BUILD_PCI_IRQS ((1<<5) | (1<<9) | (1<<10) | (1<<11)) ^ ERROR: spaces required around that '<<' (ctx:VxV) #301: FILE: hw/i386/acpi-common.c:115: +#define ACPI_BUILD_PCI_IRQS ((1<<5) | (1<<9) | (1<<10) | (1<<11)) ^ ERROR: spaces required around that '<<' (ctx:VxV) #301: FILE: hw/i386/acpi-common.c:115: +#define ACPI_BUILD_PCI_IRQS ((1<<5) | (1<<9) | (1<<10) | (1<<11)) ^ ERROR: spaces required around that '<<' (ctx:VxV) #301: FILE: hw/i386/acpi-common.c:115: +#define ACPI_BUILD_PCI_IRQS ((1<<5) | (1<<9) | (1<<10) | (1<<11)) ^ total: 4 errors, 3 warnings, 321 lines checked Patch 6/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/22 Checking commit 628859e5cd4e (acpi: madt: skip pci override on pci-less systems.) WARNING: line over 80 characters #62: FILE: hw/i386/acpi-common.c:128: + intsrcovr->flags = cpu_to_le16(0xd); /* active high, level triggered */ total: 0 errors, 1 warnings, 56 lines checked Patch 7/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/22 Checking commit ffcb8350661b (acpi: fadt: add hw-reduced sleep register support) 9/22 Checking commit 963229ef8a9a (acpi: ged: rename event memory region) 10/22 Checking commit 42157e12a08c (acpi: ged: add control regs) 11/22 Checking commit 570b71e5b8fa (acpi: ged: add x86 device variant.) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #24: new file mode 100644 total: 0 errors, 1 warnings, 51 lines checked Patch 11/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/22 Checking commit 873496e2d411 (acpi: move acpi_dsdt_add_power_button() to ged) 13/22 Checking commit 9a8690b252cc (x86: coldplug cpus) 14/22 Checking commit 8473717fafed (microvm: use 2G split unconditionally) 15/22 Checking commit b44d3ee2c4d2 (microvm: make virtio irq base runtime configurable) 16/22 Checking commit 50bd7654bd78 (microvm/acpi: add minimal acpi support) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 WARNING: Block comments use a leading /* on a separate line #39: FILE: hw/i386/acpi-microvm.c:1: +/* Support for generating ACPI tables and passing them to Guests WARNING: Block comments use a leading /* on a separate line #150: FILE: hw/i386/acpi-microvm.c:112: + table_offsets = g_array_new(false, true /* clear */, WARNING: Block comments use a leading /* on a separate line #154: FILE: hw/i386/acpi-microvm.c:116: + 64 /* Ensure FACS is aligned */, WARNING: Block comments use a leading /* on a separate line #155: FILE: hw/i386/acpi-microvm.c:117: + false /* high memory */); total: 0 errors, 5 warnings, 293 lines checked Patch 16/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/22 Checking commit f442b20044f3 (microvm/acpi: add acpi_dsdt_add_virtio() for x86) 18/22 Checking commit 00de58be2c9d (microvm/acpi: use GSI 16-23 for virtio) 19/22 Checking commit 88c8990ffa2f (microvm/acpi: use seabios with acpi=on) 20/22 Checking commit 3932159d5e0c (microvm/acpi: disable virtio-mmio cmdline hack) 21/22 Checking commit 0c46cb7b51d7 (acpi: add per machine type acpi default) 22/22 Checking commit 7280d5050ee8 (acpi: flip default to off for microvm) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200520132003.9492-1-kra...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
