On Wed, 20 May 2020 at 16:28, P J P <[email protected]> wrote: > > From: Prasad J Pandit <[email protected]> > > Disable rarely used sdhci-pci device build by default. > > Suggested-by: Stefan Hajnoczi <[email protected]> > Signed-off-by: Prasad J Pandit <[email protected]> > ---
Doesn't this break existing working command lines? The device exists, some people use it. We should treat it like other PCI devices -- if the guest arch/machine can handle PCI the device should be built. There's obviously scope for being more general and allowing some kind of "only build the subset of devices we feel more confident abut the security of" setup (don't RH do something like this downstream?), but upstream we don't have a concept like that, we just build everything. thanks -- PMM
